Bug 206037 (pear-Console-Table)

Summary:	Review Request: php-pear-Console-Table - Class that makes it easy to build console style tables
Product:	[Fedora] Fedora	Reporter:	Remi Collet <fedora>
Component:	Package Review	Assignee:	Christopher Stone <chris.stone>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	Flags:	petersen: fedora-cvs+
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-09-12 15:49:01 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779, 206052

Description Remi Collet 2006-09-11 17:07:37 UTC

Spec URL: http://remi.collet.free.fr/rpms/extras/php-pear-Console-Table.spec
SRPM URL: http://remi.collet.free.fr/rpms/extras/php-pear-Console-Table-1.0.5-1.fc5.src.rpm
Description: A pear extension for php :
Provides methods such as addRow(), insertRow(), addCol() etc. to build
console tables with or without headers.

This is a requirement for php-pear-PHP-CompatInfo

rpmlint :
W: php-pear-Console-Table no-documentation
=> no document upstream and no copy found for BSD licence.

W: php-pear-Console-Table dangerous-command-in-%post install
=> rpmlint bug

Build in mock : http://remi.collet.free.fr/rpms/extras/php-pear-Console-Table-build.log

Running : "pear run-tests -p Console_Table"
Running 7 tests
...
7 PASSED TESTS
0 SKIPPED TESTS

Note : i'm searching for a solution to include the "run-tests" in the %check, but i don't find a solution (extension must be installed).

Comment 1 Christopher Stone 2006-09-11 18:05:13 UTC

- rpmlint output:
W: php-pear-Console-Table no-documentation
W: php-pear-Console-Table dangerous-command-in-%post install

Both warnings are fine.
- package is named according to Package Naming Guidelines
- spec filename matches package %{name}
- package meets Packaging Guidelines
- package licensed with open source compatible license
- license field in spec matches actual license
- source does not include copy of license
- spec file written in American english
- spec file is l3g1bL3
- sources match upstream
23c6973122c1106673c6ccce7375c4e2  Console_table-1.0.5.tgz
- package successfully compiles and builds on x86_64 FC5
- All build dependecncies are listed in BuildRequires
- package does not use locales
- package does not contain shared libraries
- package is not relocatable
- package owns all directories it creates
- no duplicate files in %files
- File permissions are set properly
- package contains proper %clean section
- macro usage is consistent
- package contains permissible code
- no large documentation files
- %doc does not affect runtime
- no header files or static libraries
- no pkgconfig files
- no .so files
- no devel package
- no .la files
- package is not a GUI needing .desktop files
X Package owns files or directories owned by other packages


==== MUST FIX ====
- Change:

%{pear_phpdir}/Console
 
To:

%{pear_phpdir}/Console/Table.php

The %{pear_phpdir}/Console directory is owned by php-pear.  Packages that fall
under these dirs should not own them.  (NOTE:  I think you need to fix
XML_Parser for this issue as well, sorry I did not spot it earlier).

Comment 2 Remi Collet 2006-09-11 18:34:12 UTC

Spec: http://remi.collet.free.fr/rpms/extras/php-pear-Console-Table.spec
SRPM:
http://remi.collet.free.fr/rpms/extras/php-pear-Console-Table-1.0.5-2.fc5.src.rpm
Mock: http://remi.collet.free.fr/rpms/extras/php-pear-Console-Table-build.log

%changelog
* Mon Sep 11 2006 Remi Collet <Fedora> 1.0.5-2
- don't own %%{pear_phpdir}/Console

Comment 3 Remi Collet 2007-03-31 08:32:45 UTC

Package Change Request
======================
Package Name: php-pear-Console-Table
New Branches: EL-5

Comment 4 Jens Petersen 2007-04-02 13:11:55 UTC

done