Bug 2060557

Summary:	[4.10] Incorrect installation of ibmcloud vpc csi driver in IBM Cloud ROKS
Product:	OpenShift Container Platform	Reporter:	Jonathan Dobson <jdobson>
Component:	Storage	Assignee:	Jonathan Dobson <jdobson>
Storage sub component:	Operators	QA Contact:	Chao Yang <chaoyang>
Status:	CLOSED DUPLICATE	Docs Contact:
Severity:	high
Priority:	high	CC:	aos-bugs, arahamad, cschaefe, jdobson, jnowicki, jsafrane, wduan
Version:	4.10
Target Milestone:	---
Target Release:	4.10.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	2060509	Environment:
Last Closed:	2022-03-07 16:52:03 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2060509, 2061483
Bug Blocks:

Description Jonathan Dobson 2022-03-03 18:47:55 UTC

+++ This bug was initially created as a clone of Bug #2060509 +++

Description of problem:
OpenShift 4.10 IPI install should ensure that "ibmcloud vpc csi driver" is only installed for IBM Cloud when "controlPlaneTopology" (see infrastructure resource) is set to internal (or NOT external).

This was discovered during IBM ROKS 4.10 bringup (PR tests where breaking due to installation errors related to this issue).

The following components were installed (incorrectly) on a "classic infrastructure" IBM ROKS 4.10 cluster.
openshift-cluster-csi-drivers                      ibm-vpc-block-csi-controller-7f6958b-l66mb                0/5     ContainerCreating   0             46h
openshift-cluster-csi-drivers                      ibm-vpc-block-csi-driver-operator-56bf948469-8fscf        1/1     Running             0             46h
openshift-cluster-csi-drivers                      ibm-vpc-block-csi-node-d6rts                              0/3     Init:0/1            0             46h
openshift-cluster-csi-drivers                      ibm-vpc-block-csi-node-lf48n                              0/3     Init:0/1            0             46h
openshift-cluster-csi-drivers                      ibm-vpc-block-csi-node-q72kc                              0/3     Init:0/1            0             46h


Version-Release number of selected component (if applicable):
4.10

How reproducible:
IBM Cloud ROKS 4.10 PR testing - please work with IBM (jnowicki) to recreate/validate.

Steps to Reproduce:
1. Run IBM Cloud  ROKS 4.10 PR tests

Actual results:
PR tests are failing.

Expected results:
PR tests succeed.

Master Log:

Node Log (of failed PODs):

PV Dump:

PVC Dump:

StorageClass Dump (if StorageClass used by PV/PVC):

Additional info:

--- Additional comment from Jeff Nowicki on 2022-03-03 16:40:51 UTC ---

Discussion thread in CoreOS/ipi-upi-ibm-cloud slack channel: https://coreos.slack.com/archives/C01U40AM37F/p1646318513793049

Suggestion from Jan (in slack thread):
We could add some hook to CSIOperatorConfig and call it in shouldRunController with the current infrastructure. The hook for IBMCould would allow installation of the driver only when the platform != external

--- Additional comment from Jonathan Dobson on 2022-03-03 18:45:04 UTC ---

Discussed with Jeff that we'll not call it a blocker for 4.10, but a priority fix for 4.10.1. They can workaround it for now.

Comment 1 Jonathan Dobson 2022-03-03 18:49:49 UTC

This is to backport the fix to 4.10.z after bug 2060509 is fixed in the master branch.

Comment 2 Jonathan Dobson 2022-03-07 16:52:03 UTC


*** This bug has been marked as a duplicate of bug 2061483 ***