Bug 2060990
Summary: | Starting krfb from konsole sometimes resulted in a crash of xdg-desktop-portal | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Matt Fagnani <matt.fagnani> |
Component: | xdg-desktop-portal | Assignee: | David King <amigadave> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 36 | CC: | 8ru2u4gz, agurenko, amigadave, awilliam, debarshir, gnome-sig, jreznik, kde-sig, rdieter, than |
Target Milestone: | --- | Keywords: | Reopened |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | AcceptedFreezeException | ||
Fixed In Version: | xdg-desktop-portal-1.12.4-1.fc36 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2022-05-02 19:43:09 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1953786 |
Description
Matt Fagnani
2022-03-04 20:20:04 UTC
Triaging to xdg-desktop-portal (the reported item that is crashing here) (In reply to Rex Dieter from comment #1) > Triaging to xdg-desktop-portal (the reported item that is crashing here) OK thanks. I ran xdg-desktop-portal under valgrind by editing /usr/lib/systemd/user/xdg-desktop-portal.service to have a line like ExecStart=valgrind /usr/libexec/xdg-desktop-portal and rebooting. I ran krfb from konsole. An invalid write and invalid read were found by valgrind in UnknownInlinedFun at screen-cast.c:587-589 in xdg-desktop-portal-1.12.1-2.fc36.x86_64 which might've been an out-of-bounds write and read given messages like "Address 0x1a573970 is 0 bytes after a block of size 256 alloc'd" ==2350== Thread 7 pool-/usr/libex: ==2350== Invalid write of size 4 ==2350== at 0x14C2EA: UnknownInlinedFun (screen-cast.c:587) ==2350== by 0x14C2EA: handle_select_sources (screen-cast.c:785) ==2350== by 0x4FB2745: ffi_call_unix64 (unix64.S:105) ==2350== by 0x4FAF4D1: ffi_call_int.lto_priv.0 (ffi64.c:672) ==2350== by 0x4B70082: g_cclosure_marshal_generic (gclosure.c:1534) ==2350== by 0x4B69E5F: g_closure_invoke (gclosure.c:830) ==2350== by 0x4B96884: signal_emit_unlocked_R.isra.0 (gsignal.c:3783) ==2350== by 0x16BB6A: _xdp_screen_cast_skeleton_handle_method_call (xdp-dbus.c:37045) ==2350== by 0x4A9FF6A: dispatch_in_thread_func (gdbusinterfaceskeleton.c:540) ==2350== by 0x4A2DFB2: g_task_thread_pool_thread (gtask.c:1434) ==2350== by 0x4C36EF1: g_thread_pool_thread_proxy.lto_priv.0 (gthreadpool.c:354) ==2350== by 0x4C344D1: g_thread_proxy (gthread.c:827) ==2350== by 0x4DA4016: start_thread (pthread_create.c:442) ==2350== Address 0x1a573970 is 0 bytes after a block of size 256 alloc'd ==2350== at 0x484586F: malloc (vg_replace_malloc.c:381) ==2350== by 0x4C0F498: g_malloc (gmem.c:125) ==2350== by 0x4C27DA5: g_slice_alloc (gslice.c:1072) ==2350== by 0x4C29DEC: g_slice_alloc0 (gslice.c:1098) ==2350== by 0x4B92236: g_type_create_instance (gtype.c:1901) ==2350== by 0x4B79FA7: g_object_new_internal (gobject.c:2011) ==2350== by 0x4B7B75C: g_object_new_valist (gobject.c:2355) ==2350== by 0x49F705D: g_initable_new_valist (ginitable.c:244) ==2350== by 0x49F713C: g_initable_new (ginitable.c:162) ==2350== by 0x147D29: UnknownInlinedFun (remote-desktop.c:160) ==2350== by 0x147D29: handle_create_session.lto_priv.1 (remote-desktop.c:272) ==2350== by 0x4FB2745: ffi_call_unix64 (unix64.S:105) ==2350== by 0x4FAF4D1: ffi_call_int.lto_priv.0 (ffi64.c:672) ==2350== ==2350== Invalid read of size 4 ==2350== at 0x14C315: UnknownInlinedFun (screen-cast.c:589) ==2350== by 0x14C315: handle_select_sources (screen-cast.c:785) ==2350== by 0x4FB2745: ffi_call_unix64 (unix64.S:105) ==2350== by 0x4FAF4D1: ffi_call_int.lto_priv.0 (ffi64.c:672) ==2350== by 0x4B70082: g_cclosure_marshal_generic (gclosure.c:1534) ==2350== by 0x4B69E5F: g_closure_invoke (gclosure.c:830) ==2350== by 0x4B96884: signal_emit_unlocked_R.isra.0 (gsignal.c:3783) ==2350== by 0x16BB6A: _xdp_screen_cast_skeleton_handle_method_call (xdp-dbus.c:37045) ==2350== by 0x4A9FF6A: dispatch_in_thread_func (gdbusinterfaceskeleton.c:540) ==2350== by 0x4A2DFB2: g_task_thread_pool_thread (gtask.c:1434) ==2350== by 0x4C36EF1: g_thread_pool_thread_proxy.lto_priv.0 (gthreadpool.c:354) ==2350== by 0x4C344D1: g_thread_proxy (gthread.c:827) ==2350== by 0x4DA4016: start_thread (pthread_create.c:442) ==2350== Address 0x1a573970 is 0 bytes after a block of size 256 alloc'd ==2350== at 0x484586F: malloc (vg_replace_malloc.c:381) ==2350== by 0x4C0F498: g_malloc (gmem.c:125) ==2350== by 0x4C27DA5: g_slice_alloc (gslice.c:1072) ==2350== by 0x4C29DEC: g_slice_alloc0 (gslice.c:1098) ==2350== by 0x4B92236: g_type_create_instance (gtype.c:1901) ==2350== by 0x4B79FA7: g_object_new_internal (gobject.c:2011) ==2350== by 0x4B7B75C: g_object_new_valist (gobject.c:2355) ==2350== by 0x49F705D: g_initable_new_valist (ginitable.c:244) ==2350== by 0x49F713C: g_initable_new (ginitable.c:162) ==2350== by 0x147D29: UnknownInlinedFun (remote-desktop.c:160) ==2350== by 0x147D29: handle_create_session.lto_priv.1 (remote-desktop.c:272) ==2350== by 0x4FB2745: ffi_call_unix64 (unix64.S:105) ==2350== by 0x4FAF4D1: ffi_call_int.lto_priv.0 (ffi64.c:672) ==2350== ==2350== xdg-desktop-portal didn't crash under valgrind, but I only ran it a couple times with the same invalid writes and reads shown. I reported this problem at https://bugs.kde.org/show_bug.cgi?id=451166 FEDORA-2022-1ae762882c has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-1ae762882c FEDORA-2022-1ae762882c has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-1ae762882c` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-1ae762882c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. *** Bug 2056307 has been marked as a duplicate of this bug. *** FEDORA-2022-d278d588a1 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-d278d588a1 FEDORA-2022-d278d588a1 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-d278d588a1` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-d278d588a1 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-d278d588a1 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. Re-opening and nominating as Final FE, because fixing startup of krfb would be good for the KDE live (it's a default app). (In reply to Adam Williamson from comment #9) > Re-opening and nominating as Final FE, because fixing startup of krfb would > be good for the KDE live (it's a default app). Thanks. xdg-desktop-portal from xdg-desktop-portal-1.12.4-1.fc36 hasn't crashed when I've run krfb from konsole several times. krfb still doesn't start from the Application Launcher menu as reported at https://bugzilla.redhat.com/show_bug.cgi?id=2060441 Rex reported that problem with a way to fix it by removing %i from Exec=krfb -qwindowtitle %c %i in org.kde.krfb.desktop at https://bugs.kde.org/show_bug.cgi?id=451140 +5 in https://pagure.io/fedora-qa/blocker-review/issue/796 , marking accepted. FEDORA-2022-1ae762882c has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. |