Bug 2061483

Summary:	Incorrect installation of ibmcloud vpc csi driver in IBM Cloud ROKS 4.10
Product:	OpenShift Container Platform	Reporter:	OpenShift BugZilla Robot <openshift-bugzilla-robot>
Component:	Storage	Assignee:	Jonathan Dobson <jdobson>
Storage sub component:	Storage	QA Contact:	Chao Yang <chaoyang>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	high
Priority:	high	CC:	aos-bugs, arahamad, cschaefe, jdobson, jsafrane
Version:	4.10
Target Milestone:	---
Target Release:	4.10.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-03-21 12:40:07 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2060509
Bug Blocks:	2060557

Description OpenShift BugZilla Robot 2022-03-07 16:47:46 UTC

+++ This bug was initially created as a clone of Bug #2060509 +++

Description of problem:
OpenShift 4.10 IPI install should ensure that "ibmcloud vpc csi driver" is only installed for IBM Cloud when "controlPlaneTopology" (see infrastructure resource) is set to internal (or NOT external).

This was discovered during IBM ROKS 4.10 bringup (PR tests where breaking due to installation errors related to this issue).

The following components were installed (incorrectly) on a "classic infrastructure" IBM ROKS 4.10 cluster.
openshift-cluster-csi-drivers                      ibm-vpc-block-csi-controller-7f6958b-l66mb                0/5     ContainerCreating   0             46h
openshift-cluster-csi-drivers                      ibm-vpc-block-csi-driver-operator-56bf948469-8fscf        1/1     Running             0             46h
openshift-cluster-csi-drivers                      ibm-vpc-block-csi-node-d6rts                              0/3     Init:0/1            0             46h
openshift-cluster-csi-drivers                      ibm-vpc-block-csi-node-lf48n                              0/3     Init:0/1            0             46h
openshift-cluster-csi-drivers                      ibm-vpc-block-csi-node-q72kc                              0/3     Init:0/1            0             46h


Version-Release number of selected component (if applicable):
4.10

How reproducible:
IBM Cloud ROKS 4.10 PR testing - please work with IBM (jnowicki) to recreate/validate.

Steps to Reproduce:
1. Run IBM Cloud  ROKS 4.10 PR tests

Actual results:
PR tests are failing.

Expected results:
PR tests succeed.

Master Log:

Node Log (of failed PODs):

PV Dump:

PVC Dump:

StorageClass Dump (if StorageClass used by PV/PVC):

Additional info:

--- Additional comment from jnowicki.com on 2022-03-03 16:40:51 UTC ---

Discussion thread in CoreOS/ipi-upi-ibm-cloud slack channel: https://coreos.slack.com/archives/C01U40AM37F/p1646318513793049

Suggestion from Jan (in slack thread):
We could add some hook to CSIOperatorConfig and call it in shouldRunController with the current infrastructure. The hook for IBMCould would allow installation of the driver only when the platform != external

--- Additional comment from jdobson on 2022-03-03 18:45:04 UTC ---

Discussed with Jeff that we'll not call it a blocker for 4.10, but a priority fix for 4.10.1. They can workaround it for now.

Comment 1 Jonathan Dobson 2022-03-07 16:52:03 UTC

*** Bug 2060557 has been marked as a duplicate of this bug. ***

Comment 3 Chao Yang 2022-03-11 03:34:40 UTC

oc get pods
NAME                                                READY   STATUS    RESTARTS   AGE
ibm-vpc-block-csi-controller-77985945d8-k6stm       5/5     Running   0          103m
ibm-vpc-block-csi-driver-operator-94d55fdc4-gj54k   1/1     Running   0          104m
ibm-vpc-block-csi-node-gmrf4                        3/3     Running   0          103m
ibm-vpc-block-csi-node-h4m6l                        3/3     Running   0          93m
ibm-vpc-block-csi-node-j9m5p                        3/3     Running   0          103m
ibm-vpc-block-csi-node-n7666                        3/3     Running   0          94m
ibm-vpc-block-csi-node-vz2cr                        3/3     Running   0          102m
ibm-vpc-block-csi-node-wkwcd                        3/3     Running   0          92m

Passed with 4.10.0-0.nightly-2022-03-10-155847

Comment 6 errata-xmlrpc 2022-03-21 12:40:07 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.10.5 bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:0928