Bug 206222 (manaworld-music)

Summary: Review Request: manaworld-music - music for the manaworld game
Product: [Fedora] Fedora Reporter: Wart <wart>
Component: Package ReviewAssignee: Christopher Stone <chris.stone>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: panemade
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-09-23 18:00:21 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 163779    

Description Wart 2006-09-13 01:21:44 UTC
Spec URL: http://www.kobold.org/~wart/fedora/manaworld-music.spec
SRPM URL: http://www.kobold.org/~wart/fedora/manaworld-music-0.0.20-1.src.rpm
Description:
Upstream's music files for the manaworld game

Comment 1 Parag AN(पराग) 2006-09-13 12:23:21 UTC
{Not Official Reviewer}
packaging looks ok.
+ Mockbuild is successfull for i386 FC6
+ rpmlint on binary rpm is silent
+ dist tag is present
+ Buildroot is correct
+ source URL is correct
+ BR is correct
+ License used is GPL
+ License file COPYING is included
+ MD5 sum on tarball is matching upstream tarball
eec5e7d6c8ddb8938209815dbf5da812  tmwmusic-0.0.20.tar.gz
+ No duplicate files

Not tested package.

Comment 2 Christopher Stone 2006-09-23 16:56:30 UTC
- rpmlint output clean
- package named according to package naming guidelines
- spec file name matches package %{name}
- package meets packaging guidelines
- package is licensed with open source compatible license
- license matches actual license
- license is included in %doc
- spec file written in American english
- spec file is legible
- package successfully builds on x86_64 FC5
- package does not use locales
- package does not contain shared library files
- package is not relocatable
- package owns all directories it creates
- no duplicates in %files
- permissions on files set properly
- package contains proper %clean section
- macro usage is consistent
- package contains permissible content
- package does not contain large documentation
- files in %doc do not affect runtime
- no header files or static libraries present
- no pkgconfig files present
- no library files with suffix present
- no devel subpackage required
- no .la files present
- not a GUI app needing a .desktop file
- package does not own files or directories owned by other packages


Comment 3 Wart 2006-09-23 18:00:21 UTC
Imported and built.

Thanks!