Bug 2063445

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=84081098

- license needs to include zlib (with a comment describing the breakdown; bundled nanopb is zlib licensed)
- ship zlib license file too
- (optional) move desktop-file-validate and appstream-util to %check

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Dist tag is present.


===== MUST items =====

C/C++:
[-]: Provides: bundled(gnulib) in place as required.
     Note: Sources not installed
     - probably false positive, couldn't find a reference to gnulib anywhere
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     => should be "GPLv3 and zlib" since you're bundling nanopb, and put a
        comment describing the breakdown
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "zlib License", "Public domain", "BSD
     3-Clause License". 510 files have unknown license. Detailed output of
     licensecheck in
     /home/michel/src/fedora/reviews/dcavalca/2063445-qflipper/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
     => need to ship the zlib license file too
[!]: Package must own all directories that it creates.
     => need to Requires: hicolor-icon-theme
     Note: Directories without known owners:
     /usr/share/icons/hicolor/512x512/apps, /usr/share/icons/hicolor,
     /usr/share/icons/hicolor/512x512
[x]: %build honors applicable compiler flags or justifies otherwise.
[-]: Package contains no bundled libraries without FPC exception.
     => obsolete guidance, exception no longer needed approval
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 61440 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
     => move desktop-file-validate and appstream-util validate-relax to %check
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Cannot parse rpmlint output:


Rpmlint (debuginfo)
-------------------
Cannot parse rpmlint output:



Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Unversioned so-files
--------------------
qflipper: /usr/lib64/qFlipper/plugins/libflipperproto0.so

Source checksums
----------------
https://github.com/nanopb/nanopb/archive/13666952914f3cf43a70c6b9738a7dc0dd06a6dc/nanopb-13666952914f3cf43a70c6b9738a7dc0dd06a6dc.tar.gz :
  CHECKSUM(SHA256) this package     : 4b877587c1e468521a59de9a2b4fc02a3f21bfa878f2ae74da45051fb12b89e5
  CHECKSUM(SHA256) upstream package : 4b877587c1e468521a59de9a2b4fc02a3f21bfa878f2ae74da45051fb12b89e5
https://github.com/flipperdevices/qFlipper/archive/0.9.1/qFlipper-0.9.1.tar.gz :
  CHECKSUM(SHA256) this package     : 9be97c3d4bf394cbb0f6a6dc09a3f27e7978749a58fcfe1b3fc555ac7d616029
  CHECKSUM(SHA256) upstream package : 9be97c3d4bf394cbb0f6a6dc09a3f27e7978749a58fcfe1b3fc555ac7d616029


Requires
--------
qflipper (rpmlib, GLIBC filtered):
    ld-linux-aarch63.so.1()(64bit)
    libQt5Core.so.5()(64bit)
    libQt5Core.so.5(Qt_5)(64bit)
    libQt5Gui.so.5()(64bit)
    libQt5Gui.so.5(Qt_5)(64bit)
    libQt5Network.so.5()(64bit)
    libQt5Network.so.5(Qt_5)(64bit)
    libQt5Qml.so.5()(64bit)
    libQt5Qml.so.5(Qt_5)(64bit)
    libQt5Quick.so.5()(64bit)
    libQt5Quick.so.5(Qt_5)(64bit)
    libQt5QuickControls2.so.5()(64bit)
    libQt5QuickControls2.so.5(Qt_5)(64bit)
    libQt5SerialPort.so.5()(64bit)
    libQt5SerialPort.so.5(Qt_5)(64bit)
    libQt5Widgets.so.5()(64bit)
    libQt5Widgets.so.5(Qt_5)(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libusb-1.0.so.0()(64bit)
    libz.so.1()(64bit)
    rtld(GNU_HASH)
    systemd-udev

qflipper-debuginfo (rpmlib, GLIBC filtered):

qflipper-debugsource (rpmlib, GLIBC filtered):



Provides
--------
qflipper:
    application()
    application(qFlipper.desktop)
    bundled(nanopb)
    libflipperproto0.so()(64bit)
    metainfo()
    metainfo(one.flipperzero.qflipper.metainfo.xml)
    qflipper
    qflipper(aarch-64)

qflipper-debuginfo:
    debuginfo(build-id)
    libflipperproto0.so-0.9.1-1.fc37.aarch64.debug()(64bit)
    qflipper-debuginfo
    qflipper-debuginfo(aarch-64)

qflipper-debugsource:
    qflipper-debugsource
    qflipper-debugsource(aarch-64)



Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review -b 2063445
Buildroot used: fedora-rawhide-aarch64
Active plugins: C/C++, Shell-api, Generic
Disabled plugins: Java, Ocaml, R, SugarActivity, Python, Perl, PHP, Haskell, fonts
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Spec URL: https://dcavalca.fedorapeople.org/review/qflipper/qflipper.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/qflipper/qflipper-0.9.1-1.fc37.src.rpm

Changelog:
- fix license and ship missing license file

Spec URL: https://dcavalca.fedorapeople.org/review/qflipper/qflipper.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/qflipper/qflipper-0.9.1-1.fc37.src.rpm

Changelog:
- move desktop and appdata validation to %check

LGTM, package APPROVED

Thanks!

$ fedpkg request-repo qflipper 2063445
https://pagure.io/releng/fedora-scm-requests/issue/42955

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/qflipper

FEDORA-2022-ff44bc1c07 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-ff44bc1c07

FEDORA-2022-ff44bc1c07 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2022-2bfaa0888e has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-2bfaa0888e

FEDORA-2022-928cbc9cd9 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-928cbc9cd9

FEDORA-2022-928cbc9cd9 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-928cbc9cd9 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-928cbc9cd9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2022-2bfaa0888e has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-2bfaa0888e \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-2bfaa0888e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2022-928cbc9cd9 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2022-2bfaa0888e has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.