Bug 2063554
| Summary: | Review Request: rust-fontconfig-parser - fontconfig file parser in pure Rust | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rémi Lauzier <remilauzier> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | decathorpe, package-review, remilauzier |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-03-24 17:47:42 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2063501, 2066734, 2066736 | ||
|
Description
Rémi Lauzier
2022-03-13 17:42:29 UTC
Did you not use rpmautospec on purpose, or did you get hit with it not being enabled by default due to a bug in rust2rpm 21-1? That issue should be fixed with rust2rpm 21-2. Feel free to regenerate the .spec file with rpmautospec before you import it to Fedora. You might also want to remove the "criterion" dev-dependency: - It's only used for compiling benchmarks (which we never do). - It pulls in lots of dependencies into your build, making it slower. - It and its dependencies take ages to compile, making your build slower. See here for an example how I usually handle this: https://src.fedoraproject.org/rpms/rust-httpdate/blob/rawhide/f/rust-httpdate.spec#_17 https://src.fedoraproject.org/rpms/rust-httpdate/blob/rawhide/f/httpdate-fix-metadata.diff You should also look into all the extraneous files that are shipped with the crate, for example "gen.sh" and "test-conf" directory. They probably should not be shipped with the RPMs we build. You could exclude them with a Cargo.toml patch, or by using %exclude %{crate_instdir}/gen.sh %exclude %{crate_instdir}/test-conf/ in the %files list of the -devel subpackage. Other than that, package looks good. === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches Thought it was on purpose that rust2rpm change the behavior! Thanks for the review. No, it was a bug in rust2rpm 21. https://pagure.io/fedora-rust/rust2rpm/issue/184 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-fontconfig-parser FEDORA-2022-ebab16285d has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-ebab16285d FEDORA-2022-ebab16285d has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-bf6d4bc3de has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-bf6d4bc3de FEDORA-2022-303f8a255a has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-303f8a255a FEDORA-2022-8d6e154791 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2022-8d6e154791 FEDORA-2022-bf6d4bc3de has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-bf6d4bc3de \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-bf6d4bc3de See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-8d6e154791 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-8d6e154791 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-8d6e154791 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-303f8a255a has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-303f8a255a \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-303f8a255a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-bf6d4bc3de has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-303f8a255a has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-8d6e154791 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. |