Bug 2063802

Summary: When converting disk allocation type the disk is being removed instead
Product: [oVirt] ovirt-engine Reporter: sshmulev
Component: BLL.StorageAssignee: Benny Zlotnik <bzlotnik>
Status: CLOSED CURRENTRELEASE QA Contact: Ilia Markelov <imarkelo>
Severity: high Docs Contact:
Priority: unspecified    
Version: 4.5.0CC: aefrat, ahadas, bugs, bzlotnik, eshames, sfishbai
Target Milestone: ovirt-4.5.0Keywords: ZStream
Target Release: 4.5.0Flags: sbonazzo: ovirt-4.5+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ovirt-engine-4.5.0 Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-04-20 06:33:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 977778    

Description sshmulev 2022-03-14 12:18:12 UTC
Versions:
4.5.0-596.7434eeb1dde2.226.el8ev
vdsm-4.50.0.8-1.el8ev
Active datacenter Compatibility Version - 4.6
Active cluster Compatibility Version

Description:
Trying to make disk convert (new feature in 4.5): tried to convert the allocation policy from preallocated to thin
Cow-Preallocated-Incr_Enabled  ->>  Cow-Thin-Incr_Enabled

Steps to reproduce:
1. Create disk a floating disk:
/ovirt-engine/api/disks

body:
<disk>
  <storage_domains>
    <storage_domain id="{{ISCSI_SD}}"/>
  </storage_domains>
  <name>Cow-Preallocated-Incr_Enabled</name>
  <provisioned_size>1073741824</provisioned_size>
  <format>cow</format>
  <sparse>false</sparse>
  <backup>incremental</backup>
</disk>

2. Convert the disk allocation policy:

/ovirt-engine/api/disks/{{disk_id}}/convert

body:

<action>
    <disk>
        <sparse>true</sparse>
        <format>cow</format>
    </disk>
</action>


Actual result:
The disk has been removed instead of being converted accordingly.

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<action>
    <disk>
        <format>cow</format>
        <sparse>true</sparse>
    </disk>
    <fault>
        <detail>[]</detail>
        <reason>Operation Failed</reason>
    </fault>
    <status>failed</status>
</action>

2022-03-14 12:57:12,594+02 ERROR [org.ovirt.engine.core.bll.storage.disk.image.ConvertDiskCommand] (default task-27) [7610aa61-37b0-4779-81f6-3532f9bc0cac] Could not find a host to perform conversion
2022-03-14 12:57:12,606+02 ERROR [org.ovirt.engine.api.restapi.resource.AbstractBackendResource] (default task-27) [] Operation Failed: []


Expected result:
The disk should be converted successfully to sparse (thin) allocation

Comment 5 Ilia Markelov 2022-03-31 15:42:34 UTC
Verified.

Successfully converted the disk to sparse allocation by following the steps.

Versions:
4.5.0-0.237.el8ev
vdsm-4.50.0.10-1.el8ev.x86_64
Active datacenter Compatibility Version - 4.7
Active cluster Compatibility Version - 4.7

Comment 6 Sandro Bonazzola 2022-04-20 06:33:59 UTC
This bugzilla is included in oVirt 4.5.0 release, published on April 20th 2022.

Since the problem described in this bug report should be resolved in oVirt 4.5.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.