Bug 2063875

Summary:	Not possible to make disk convert to all disks possibilities
Product:	[oVirt] ovirt-engine	Reporter:	sshmulev
Component:	BLL.Storage	Assignee:	Benny Zlotnik <bzlotnik>
Status:	CLOSED CURRENTRELEASE	QA Contact:	sshmulev
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	4.5.0	CC:	ahadas, bugs, bzlotnik, sfishbai
Target Milestone:	ovirt-4.5.0	Flags:	sbonazzo: ovirt-4.5+ pm-rhel: planning_ack? pm-rhel: devel_ack+ pm-rhel: testing_ack?
Target Release:	4.5.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ovirt-engine-4.5.0	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-04-20 06:33:59 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description sshmulev 2022-03-14 14:49:10 UTC

Description of problem:
Not possible to do convert to disk format/allocation policy to some of the permutations of the disk which are possible.

For example, if we want to convert block storage disk raw/preallocated/incremental-disabled -->> cow/thin/incremental-enabled, it is not possible within the new feature.
Since it is not possible to change the disk to incremental backup before the convert because raw/preallocated can be only incremenatl disabled,
I whould suggest to add also <backup> option within the body request:

POST http://engine/ovirt-engine/api/disks/123/convert
<action>
    <disk>
        <sparse>true</sparse>
        <format>raw</format>
        <backup>Incremenatl/None</backup>
    </disk>
</action>

Comment 4 sshmulev 2022-04-03 06:15:22 UTC

Verified Successfully.

Verified on all the supported storage types: NFS, GLUSERT, ISCSI, ISCSI_GW, FCP 
converted to all disk possible properties:

file:
raw		preallocated		disabled
raw		(sparse)Thin		disabled
cow		(sparse)Thin		enabled
cow		preallocated		enabled

Block:
raw		preallocated		disabled
cow		preallocated		enabled
cow		(sparse)Thin		enabled

Versions:
engine-Version 4.5.0-0.237.el8ev
vdsm-4.50.0.10-1.el8ev

Steps:
POST http://engine/ovirt-engine/api/disks/123/convert
<action>
    <disk>
        <sparse>true/false</sparse>
        <format>raw/cow</format>
        <backup>incremenatl/None</backup>
    </disk>
</action>

Expected results:
The disk should be converted according to the requested parameters.
Disk data should be the same - Data integrity can be checked by checksum_disk.py  from the examples SDK script.

Actual results:
As expected.

Comment 5 Sandro Bonazzola 2022-04-20 06:33:59 UTC

This bugzilla is included in oVirt 4.5.0 release, published on April 20th 2022.

Since the problem described in this bug report should be resolved in oVirt 4.5.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.