Bug 2063877

Summary:	Deprecated terminology "Master/Slave" is present in some resource agents' metadata
Product:	Red Hat Enterprise Linux 9	Reporter:	Michal Mazourek <mmazoure>
Component:	resource-agents	Assignee:	Oyvind Albrigtsen <oalbrigt>
Status:	CLOSED ERRATA	QA Contact:	cluster-qe <cluster-qe>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	9.0	CC:	agk, cluster-maint, fdinitto, tojeline
Target Milestone:	rc	Keywords:	Triaged
Target Release:	9.1
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	resource-agents-4.10.0-18.el9	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-11-15 09:44:01 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Michal Mazourek 2022-03-14 14:51:27 UTC

Description of problem:
In RHEL9, roles 'Master' and 'Slave' are deprecated and should not be used anymore. Some agents are still using this terminology: "ocf:heartbeat:db2", "ocf:heartbeat:galera", "ocf:heartbeat:mysql", "ocf:heartbeat:pgsql", "ocf:heartbeat:redis", "ocf:heartbeat:conntrackd" and possibly others. 


Version-Release number of selected component (if applicable):
resource-agents-4.10.0-7.el9.x86_64


How reproducible:
always


Steps to Reproduce:
[root@virt-498 cli]# crm_resource --show-metadata ocf:heartbeat:conntrackd | grep -i 'master\|slave'
Master/Slave OCF Resource Agent for conntrackd
<action name="monitor" timeout="20s" interval="20s" role="Slave" />
<action name="monitor" timeout="20s" interval="10s" role="Master" />


Actual results:
Master/Slave terminology is present


Expected results:
Promoted/Unpromoted terminology should be used instead

Comment 1 Tomas Jelinek 2022-03-14 15:57:25 UTC

Note that pcs translates old names to new ones in actions only:

# rpm -q pcs
pcs-0.11.1-10.el9.x86_64

# pcs resource describe ocf:heartbeat:conntrackd
ocf:heartbeat:conntrackd - This resource agent manages conntrackd

Master/Slave OCF Resource Agent for conntrackd

Resource options:
  binary: Name of the conntrackd executable. If conntrackd is installed and available in the default PATH, it is sufficient to configure the name of the binary For example "my-conntrackd-binary-version-0.9.14" If conntrackd is installed somewhere else, you may also give
          a full path For example "/packages/conntrackd-0.9.14/sbin/conntrackd"
  config: Full path to the conntrackd.conf file. For example "/packages/conntrackd-0.9.14/etc/conntrackd/conntrackd.conf"

Default operations:
  start: interval=0s timeout=30s
  promote: interval=0s timeout=30s
  demote: interval=0s timeout=30s
  notify: interval=0s timeout=30s
  stop: interval=0s timeout=30s
  monitor: interval=20s role=Unpromoted timeout=20s
  monitor: interval=10s role=Promoted timeout=20s

Comment 2 Oyvind Albrigtsen 2022-06-16 11:40:46 UTC

https://github.com/ClusterLabs/resource-agents/pull/1779

Comment 9 errata-xmlrpc 2022-11-15 09:44:01 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (resource-agents bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:7932