Bug 2064553

Summary: UI should prefer to use the virtio-win configmap than v2v-vmware configmap for windows creation
Product: OpenShift Container Platform Reporter: Guohua Ouyang <gouyang>
Component: Console Kubevirt PluginAssignee: Oren Cohen <ocohen>
Status: CLOSED ERRATA QA Contact: Guohua Ouyang <gouyang>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.11CC: aos-bugs, cnv-qe-bugs, gouyang, ocohen, stirabos
Target Milestone: ---   
Target Release: 4.11.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-08-10 10:54:28 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2078385    
Attachments:
Description Flags
v2v-vmware cm
none
virtio-win cm none

Description Guohua Ouyang 2022-03-16 07:25:28 UTC 
Description of problem:
On a cluster that has both v2v-vmware and virtio-win configmaps to provide virtio-win-image for windows VM creation, UI should prefer to use virtio-win than v2v-vmware configmap

Version-Release number of selected component (if applicable):
4.10.4

How reproducible:
100%

Steps to Reproduce:
1. upgrade cluster from 4.8 to 4.10
2. create a windows VM
3.

Actual results:
Windows guest tool disk is using image from v2v-vmware

Expected results:
Windows guest tool disk is using image from virtio-win

Additional info:
Comment 1 Guohua Ouyang 2022-03-16 07:26:38 UTC 
Created attachment 1866151 [details]
v2v-vmware cm
Comment 2 Guohua Ouyang 2022-03-16 07:28:03 UTC 
Created attachment 1866152 [details]
virtio-win cm
Comment 4 Oren Cohen 2022-03-21 13:00:56 UTC 
This BZ is handled both in UI and in HCO.
In UI, the reference for the deprecated configmap "v2v-vmware" is being removed:
https://github.com/openshift/console/pull/11207

In HCO, we'll remove the deprecated v2v-vmware ConfigMap on upgrade to the next version using a new mechanism for leftovers removal using a json file:
https://github.com/kubevirt/hyperconverged-cluster-operator/pull/1824 (currently WIP)
Comment 5 Oren Cohen 2022-03-23 14:58:52 UTC 
Guohua, do we want to backport the fix also for 4.10.z?
Comment 8 Guohua Ouyang 2022-04-25 07:40:32 UTC 
(In reply to Oren Cohen from comment #5)
> Guohua, do we want to backport the fix also for 4.10.z?

I think we should backport the fix to 4.10.z.
Comment 9 Oren Cohen 2022-04-28 08:32:47 UTC 
Hi @gouyang ,
Could you please move this BZ (targeting 4.11) to verified, so the backport to 4.10 (https://bugzilla.redhat.com/show_bug.cgi?id=2078385, https://github.com/openshift/console/pull/11387) could be merged?
Comment 10 Guohua Ouyang 2022-04-28 10:58:21 UTC 
On a cluster which hava CNV upgrade from 4.9.z to 4.10.z, and then could reproduce the bug on OCP upstream 4.10 and verified this on OCP upstream 4.11.
Comment 12 errata-xmlrpc 2022-08-10 10:54:28 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Container Platform 4.11.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5069