Bug 2065015

Summary:	"Sync Connect Timeout" settings takes invalid value and shows update successful but doesn't reflect the change for invalid values
Product:	Red Hat Satellite	Reporter:	Shweta Singh <shwsingh>
Component:	Settings	Assignee:	Jeremy Lenz <jlenz>
Status:	CLOSED ERRATA	QA Contact:	Shweta Singh <shwsingh>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	6.10.4	CC:	apatel, mhulan, oezr, pcreech, rlavi
Target Milestone:	6.11.0	Keywords:	Regression, Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	foreman-3.1.1.21-1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-07-05 14:34:27 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Shweta Singh 2022-03-17 06:25:14 UTC

Description of problem:
"Sync Connect Timeout" settings takes invalid value and shows update successful but doesn't reflect the change for invalid values.

Version-Release number of selected component (if applicable):
6.10.4 and 7.0

How reproducible:
Always

Steps to Reproduce:
UI:
1. Administer -> Settings -> Content -> Sync Connection Timeout
2. Edit the value to any invalid value eg. -1 and submit it

CLI:
hammer settings set --id sync_connect_timeout_v2 --value -1

Actual results:
UI:
Displays value updated successfully but doesn't get reflected on the value

CLI:
Setting [sync_connect_timeout_v2] updated to [60].

Expected results:
Error should be displayed for invalid values

Additional info:
This behavior is consistent on CLI, API and UI.

Comment 1 Shweta Singh 2022-03-17 14:39:11 UTC

This settings works perfectly fine on Satellite 6.10.3 and throws error on invalid values

Comment 3 Jeremy Lenz 2022-04-28 20:15:15 UTC

Created redmine issue https://projects.theforeman.org/issues/34838 from this bug

Comment 4 Bryan Kearney 2022-04-29 00:05:08 UTC

Upstream bug assigned to jlenz

Comment 5 Ron Lavi 2022-05-09 08:46:04 UTC

Upstream PR got merged

Comment 7 Shweta Singh 2022-05-16 07:29:12 UTC

The BZ is fixed but the error message for invalid input contains additional info which is not consistent with the satellite error messages. Dev is going to shorten the error message so assigning this BZ back to Dev.

Comment 8 Ron Lavi 2022-05-22 12:38:41 UTC

The second upstream PR got merged, which makes the error message look nicer,
Moving this to POST.

for example from:

`ERF07-1096 [Foreman::SettingValueException]: error parsing value for setting 'sync_connect_timeout_v2': Value is invalid: must be integer`

to be just:

`Error parsing value for setting 'sync_connect_timeout_v2': Value is invalid: must be integer`

The original issue got fixed and seems that it made its way to 6.11.0 and was Fixed In Version: foreman-3.1.1.19-1 (snap_6.11.0_20.0)
Do we want to get the second fix to 6.11.z ? or close this Bugzilla for now?

Comment 9 Brad Buckingham 2022-05-23 13:24:03 UTC

Hi Ron,

Thanks for raising.

Since the change for the error message was small and in review, we left this one proposed to 6.11 and will bring it in as part of the post freeze snaps.

Comment 11 Shweta Singh 2022-05-31 06:33:07 UTC

Verified.

Version Tested: Satellite 6.11 Snap 22

The BZ and error message is fixed and verified.

Comment 14 errata-xmlrpc 2022-07-05 14:34:27 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Satellite 6.11 Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5498