Bug 2065282

Description of problem:
Invalid YAML syntax crashes overcloud redeployment.

This patch https://review.opendev.org/c/openstack/tripleo-heat-templates/+/818629 added some lines, that when being concatenated in policy.yaml file, returns the following error:
  File "/usr/lib/python3.6/site-packages/oslo_policy/policy.py", line 413, in parse_file_contents
    raise ValueError(str(e))
ValueError: while parsing a block mapping
  in "<unicode string>", line 1, column 1:
    'add_image': 'role:admin or (rol ... 
    ^   
expected <block end>, but found '<scalar>'
  in "<unicode string>", line 22, column 110:
     ... or project_id:%(member_id)s or 'community':%(visibility)s or 'pu ... 

See https://bugzilla.redhat.com/show_bug.cgi?id=2064290



Running yamllint on the policy_file=/etc/glance/policy.yaml file, I get:
yamllint policy.yaml 
policy.yaml
  1:1       warning  missing document start "---"  (document-start)
  1:81      error    line too long (97 > 80 characters)  (line-length)
  22:81     error    line too long (191 > 80 characters)  (line-length)
  23:81     error    line too long (186 > 80 characters)  (line-length)
  24:81     error    line too long (81 > 80 characters)  (line-length)
  26:81     error    line too long (101 > 80 characters)  (line-length)
  27:81     error    line too long (102 > 80 characters)  (line-length)
  28:81     error    line too long (113 > 80 characters)  (line-length)
  29:81     error    line too long (85 > 80 characters)  (line-length)
  30:81     error    line too long (110 > 80 characters)  (line-length)
  31:81     error    line too long (111 > 80 characters)  (line-length)
  32:81     error    line too long (114 > 80 characters)  (line-length)
  33:81     error    line too long (112 > 80 characters)  (line-length)
  34:81     error    line too long (117 > 80 characters)  (line-length)
  35:81     error    line too long (107 > 80 characters)  (line-length)
  36:81     error    line too long (108 > 80 characters)  (line-length)
  39:81     error    line too long (119 > 80 characters)  (line-length)
  54:81     error    line too long (81 > 80 characters)  (line-length)
  22:110    error    syntax error: expected <block end>, but found '<scalar>' (syntax)

^^^^^^^^
Which happened because of this line https://review.opendev.org/c/openstack/tripleo-heat-templates/+/818629/1/environments/enable-secure-rbac.yaml#1530

The invalid line in policy.yaml was
'download_image': 'role:admin or (role:member and (project_id:%(project_id)s or project_id:%(member_id)s or 'community':%(visibility)s or 'public':%(visibility)s or 'shared':%(visibility)s))'

Note: the usage of single comma (') repeats in many more lines.



This bug prevents applying the new Secure RBAC policy in OSP17, TripleO.

Version-Release number of selected component (if applicable):
[stack@undercloud-0 ~]$ cat /etc/rhosp-release 
Red Hat OpenStack Platform release 17.0.0 Beta (Ussuri)

How reproducible:
100%

Steps to Reproduce:
1. Deploy OSP17, TripleO with Octavia
2. Add /home/stack/overcloud-deploy/overcloud/tripleo-heat-templates/environments/enable-secure-rbac.yaml to /home/stack/overcloud_deploy.sh
3. Redeploy /home/stack/overcloud_deploy.sh 

Actual results:
The deployment failed when trying to upload amphora image to glance, because of the error mentioned above.

Expected results:
The deployment pass.