Bug 2065349
Summary: | acpica-tools' spec file %check run of ASL tests on s390x segfaults | ||
---|---|---|---|
Product: | Red Hat Enterprise Linux 9 | Reporter: | Dean Nelson <dnelson> |
Component: | acpica-tools | Assignee: | Dean Nelson <dnelson> |
Status: | CLOSED ERRATA | QA Contact: | Jiri Dluhos <jdluhos> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 9.0 | CC: | jdluhos |
Target Milestone: | rc | Keywords: | Triaged |
Target Release: | 9.2 | ||
Hardware: | s390x | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | acpica-tools-20210604-4.el9 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2023-05-09 08:15:57 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Dean Nelson
2022-03-17 18:14:46 UTC
NB: this currently occurs in the upstream 20211217 release, and Fedora, as well: run 'iasl -T all' and the segfault occurs. Investigating, (In reply to Al Stone from comment #1) > NB: this currently occurs in the upstream 20211217 release, and Fedora, as > well: run 'iasl -T all' and the segfault occurs. Thanks for the info. Very helpful. I was curious and as a learning exercise I tried running iasl directly, and noticed that 3 of the tables result in a segfault. All of which end up with rather large .asl files (unlike the other tables)... [root@s390x-kvm testing-dir]# ls -l prmt.asl rgrt.asl svkl.asl -rw-r--r--. 1 root root 3829760 Mar 22 13:23 prmt.asl -rw-r--r--. 1 root root 1564672 Mar 22 13:24 rgrt.asl -rw-r--r--. 1 root root 6201344 Mar 22 13:27 svkl.asl [root@s390x-kvm testing-dir]# The contents of each, look like something is getting into a loop and not letting go until the segfault terminates things. So rather than 'all' to reproduce this problem, one can run any of the following... iasl -T prmt iasl -T rgrt iasl -T svkl and get a segfault. (In reply to Dean Nelson from comment #2) > So rather than 'all' to reproduce this problem, one can run any of the > following... > > iasl -T prmt > iasl -T rgrt > iasl -T svkl > > and get a segfault. So back at the end of March 2022, I created three patches, one for each of these segfaults, and sent them to Al Stone... 0047-Support-PRMT-in-a-big-endian-world.patch 0048-Support-RGRT-in-a-big-endian-world.patch 0049-Support-SVKL-in-a-big-endian-world.patch He added them to Fedora Rawhide via fc3eef63e813 ("Update to 20220331 upstream sources"). I plan on backporting a portion of fc3eef63e813 (just these three patches, not the update to 20220331) for RHEL-9.2. And I'll be setting the DTM value shortly.(I first want to talk with Jiri Dluhos about this and two other acpica-tools BZs, that I'd like to do for 9.2.) (In reply to Dean Nelson from comment #2) > > So rather than 'all' to reproduce this problem, one can run any of the > following... > > iasl -T prmt > iasl -T rgrt > iasl -T svkl > > and get a segfault. And after eliminating the segfaults, there was the following showing up when running tests/aslts.sh... make: *** [Makefile:25: prmt.aml] Error 255 (With their segfaults eliminated, the other two tables PASS'd the test.) To reproduce the 'Error 255' simply run... iasl -T prmt iasl prmt.asl And the fix for this is also in the posted MR... https://gitlab.com/redhat/centos-stream/rpms/acpica-tools/-/merge_requests/4 Verified:Tested (see below), big thanks for excellent bug description and perfect how-to for reproducing! It's a joy working with such bugreports! :) --------------------- With the original acpica-tools, the crash is easy to reproduce: # rpm -q acpica-tools acpica-tools-20210604-3.el9.s390x # iasl -T prmt Segmentation fault (core dumped) --------------------- With the patch, everything works as expected: # rpm -q acpica-tools acpica-tools-20210604-4.el9.s390x # iasl -T prmt Created ACPI table template for [PRMT], written to "prmt.asl" # iasl -T rgrt Created ACPI table template for [RGRT], written to "rgrt.asl" # iasl -T svkl Created ACPI table template for [SVKL], written to "svkl.asl" # iasl prmt.asl Intel ACPI Component Architecture ASL+ Optimizing Compiler/Disassembler version 20210604 Copyright (c) 2000 - 2021 Intel Corporation Table Input: prmt.asl - 6711 bytes 110 fields 135 source lines Binary Output: prmt.aml - 696 bytes Compilation successful. 0 Errors, 0 Warnings, 0 Remarks # echo $? 0 Confirming that with acpica-tools-20210604-5, all commands mentioned in comment#2 and #7 work as expected: # iasl -T prmt Created ACPI table template for [PRMT], written to "prmt.asl" # iasl -T rgrt Created ACPI table template for [RGRT], written to "rgrt.asl" # iasl -T svkl Created ACPI table template for [SVKL], written to "svkl.asl" # iasl prmt.asl Intel ACPI Component Architecture ASL+ Optimizing Compiler/Disassembler version 20210604 Copyright (c) 2000 - 2021 Intel Corporation Table Input: prmt.asl - 6711 bytes 110 fields 135 source lines Binary Output: prmt.aml - 696 bytes Compilation successful. 0 Errors, 0 Warnings, 0 Remarks (With the older acpica-tools, a segfault occurred immediately after the first command.) Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (acpica-tools bug fix and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2023:2477 |