Bug 2065537

Summary:	Observability - the backup/restore labels are not added on specific resources
Product:	Red Hat Advanced Cluster Management for Kubernetes	Reporter:	cqu
Component:	Core Services / Observability	Assignee:	Chunlin Yang <chuyang>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Xiang Yin <xiyin>
Severity:	urgent	Docs Contact:
Priority:	unspecified
Version:	rhacm-2.5	CC:	cqu, smeduri
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-10-03 20:21:49 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description cqu 2022-03-18 06:18:33 UTC

Description of the problem: the backup/restore labels are not added on specific resources. As the user story - https://github.com/stolostron/backlog/issues/18324 list, these secret/configmap should be added backup/restore labels, but not, like observability-server-ca-certs, alertmanager-config, etc.

Release version: 2.5

Operator snapshot version:

OCP version: 4.10

Browser Info:

Steps to reproduce:
1. Deploy ACM and Observability
2. 
create one custom rule for alert ClusterCPUHealth-jb and forward to slack channel

create one cm observability-metrics-custom-allowlist for collecting node_memory_Active_bytes and stop collecting cluster:capacity_cpu_cores:sum

create one cm sample-dashboard for custom dashboard

create one grafana-dev instance
3. Check secret and configmap labels for backup/restore
4. only these resources have backup/restore labels
```
# oc get secret -n open-cluster-management-observability -l cluster.open-cluster-management.io/backup
NAME                          TYPE     DATA   AGE
observability-grafana-certs   Opaque   3      16h
observability-server-certs    Opaque   3      16h

# oc get configmap -n open-cluster-management-observability -l cluster.open-cluster-management.io/backup
NAME                                     DATA   AGE
clustercpu                               1      69m
observability-metrics-custom-allowlist   1      111m
sample-dashboard                         1      100m
thanos-ruler-custom-rules                1      88m
```

Actual results:

Expected results:

Additional info:

Comment 2 cqu 2022-03-31 03:19:09 UTC

I verified with 2.5.0-DOWNSTREAM-2022-03-29-05-04-50, issue is fixed. Thanks.