Bug 2065591

Summary: tuned.service has a dependency on polkit which isn't necessary
Product: Red Hat Enterprise Linux 8 Reporter: Renaud Métrich <rmetrich>
Component: tunedAssignee: Jaroslav Škarvada <jskarvad>
Status: CLOSED ERRATA QA Contact: Robin Hack <rhack>
Severity: medium Docs Contact:
Priority: medium    
Version: 8.5CC: jeder, jskarvad
Target Milestone: rcKeywords: AutoVerified, Patch, TestCaseNeeded, Triaged, Upstream
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: tuned-2.20.0-0.1.rc1.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-05-16 09:12:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Renaud Métrich 2022-03-18 09:38:35 UTC 
Description of problem:

Since 2016, tuned.service has a Requires dependency on polkit.service:
-------- 8< ---------------- 8< ---------------- 8< ---------------- 8< --------
Requires=dbus.service polkit.service
-------- 8< ---------------- 8< ---------------- 8< ---------------- 8< --------

IMHO this dependency is overkill and brings trouble.
Indeed, with such dependency, as soon as polkit gets restarted (e.g. due to having a "systemctl try-restart polkit.service" in RPM snippets), this leads to tuned.service being restarted as well.

IMHO the following dependency is enough:
-------- 8< ---------------- 8< ---------------- 8< ---------------- 8< --------
After=polkit.service
-------- 8< ---------------- 8< ---------------- 8< ---------------- 8< --------

Quick testing shows that with the above dependency only, tuned works fine at boot.
Also upon stopping polkit service and issuing a "tuned-adm active" command, the polkit service is started automatically and the command works just fine.


Version-Release number of selected component (if applicable):

tuned-2.16.0-1.el8.noarch


How reproducible:

Always

Steps to Reproduce:
1. Stop polkit.service

  # systemctl stop polkit

Actual results:

tuned.service also stops

Expected results:

tuned.service continues normally

Additional info:

Makes any "tuned-adm" command unavailable.
Comment 1 Jaroslav Škarvada 2022-10-11 10:20:58 UTC 
I think you are right, polkit has D-bus activation, thus we don't need to explictly require it.

Upstream PR:
https://github.com/redhat-performance/tuned/pull/465
Comment 13 errata-xmlrpc 2023-05-16 09:12:54 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (tuned bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:3062