Bug 2066026

Summary: Accessing Enki's settings generates an internal exception
Product: [Fedora] Fedora Reporter: Ian Laurie <nixuser>
Component: enkiAssignee: Raphael Groner <projects.rg>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: high    
Version: 36CC: anatoli, kde-sig, projects.rg, python-sig
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: enki-22.08.0-1.fc36 enki-22.08.0-1.fc35 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-08-25 16:17:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2117236    
Bug Blocks:    
Attachments:
Description Flags
Opening this C file causes an Enki exception none

Description Ian Laurie 2022-03-20 02:50:18 UTC
Description of problem:
Accessing Enki's settings generates an internal exception.

Version-Release number of selected component (if applicable):
enki-21.11.0-2.fc36.noarch

How reproducible:
Always

Steps to Reproduce:
1. Launch Enki.
2. Select Settings->Settings.
3.

Actual results:
Internal exception.

Comment 1 Ian Laurie 2022-03-20 04:44:14 UTC
Further testing reveals that loading almost any file into Enki causes it to throw an internal exception.

I managed to load a shell script of about 50 lines into it, but as I scrolled the file, it threw an exception.  Larger C files kill it on file load.

Comment 2 Raphael Groner 2022-03-20 15:19:42 UTC
Thanks for your report.

Can you maybe attach a sample file that leads to crash enki? Might be an issue with codec, but no concrete idea without more information provided.

Tried with enki-21.11.0-1.fc35.noarch to open a small text file, that works so far. But you're right about Settings>Settings:

Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/enki/core/uisettings.py", line 417, in _onEditSettings
    dialog = UISettings(core.mainWindow())
  File "/usr/lib/python3.10/site-packages/enki/core/uisettings.py", line 315, in __init__
    self.resize(max(hint.width(), hint.height() * 1.61), hint.height())
TypeError: arguments did not match any overloaded call:
  resize(self, QSize): argument 1 has unexpected type 'float'
  resize(self, int, int): argument 1 has unexpected type 'float'

Well, I assume an issue with python 3.10+ then, introduced with Fedora 35.

Comment 3 Raphael Groner 2022-03-20 15:21:06 UTC
s/codec/encoding of that specific file/

Comment 4 Raphael Groner 2022-03-20 15:22:42 UTC
Wondering what multiplication with "1.61" means in the backtrace.

Comment 5 Ian Laurie 2022-03-20 20:47:02 UTC
I can provide a C file that triggers the issue, just need a little time.  These issues with LXQt came about during my beta 1.2 testing here:
  
    https://fedoraproject.org/wiki/Test_Results:Fedora_36_Beta_1.2_Desktop

I no longer have the VM I was using for testing, but I can install Enki on a different Xfce host and try to reproduce the problem later today.

Comment 6 Ian Laurie 2022-03-20 22:56:27 UTC
Created attachment 1867023 [details]
Opening this C file causes an Enki exception

This file will cause Enki to generate an exception when the file loads.  On some other files, the file loads OK but Enki generates an exception when the file is scrolled.  Overall I would say most C files cause the problem, either on load or on scroll.

Comment 7 Fedora Update System 2022-08-17 16:10:27 UTC
FEDORA-2022-3cd4e699ca has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-3cd4e699ca

Comment 8 Fedora Update System 2022-08-17 16:13:35 UTC
FEDORA-2022-8cf9d64c36 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-8cf9d64c36

Comment 9 Ian Laurie 2022-08-17 23:41:39 UTC
Along with the update to python-qutepart enki is now working in Fedora 35, 36 and 37 beta branch.  Thanks!

Comment 10 Ian Laurie 2022-08-18 00:16:53 UTC
Very sorry, I spoke too soon.  

I had just tested it with C files which were immediately failing before (but now seem to work, or at least work better).  

However Python scripts cause the same exception as before, either on load or when you scroll a loaded file.  It's an instant exception.

FWIW bash shell scripts seem to be OK as well, but I'll do more testing across different file types and confirm if some types work, or simply work better and cause eventual crashes also.

Comment 11 Ian Laurie 2022-08-18 00:57:05 UTC
I can load and scroll and edit Python files if I disable (uncheck) the Flake8 Python lint feature (Settings->Lint->Python).

Also, the CTL-L keyboard shortcut (Navigation->Locator) causes an exception regardless of file type, and even if there is no file.

Comment 12 Fedora Update System 2022-08-18 02:55:32 UTC
FEDORA-2022-8cf9d64c36 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-8cf9d64c36`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-8cf9d64c36

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2022-08-18 03:30:44 UTC
FEDORA-2022-3cd4e699ca has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-3cd4e699ca`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-3cd4e699ca

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2022-08-19 01:27:56 UTC
FEDORA-2022-8cf9d64c36 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Ian Laurie 2022-08-19 01:47:00 UTC
Problems do persist, see comments #10 and #11.

Comment 16 Anatoli Babenia 2022-08-19 03:05:05 UTC
But the original bug is gone, so I would say these crashes deserve separate bug reports if settings work ok. It becomes hard to test this bug if one needs to swim in comments.

Comment 17 Fedora Update System 2022-08-25 16:17:58 UTC
FEDORA-2022-3cd4e699ca has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.