Bug 2066262

Summary: Fallback to CAPI annotations
Product: OpenShift Container Platform Reporter: Alberto <agarcial>
Component: Cloud ComputeAssignee: Alberto <agarcial>
Cloud Compute sub component: Cluster Autoscaler QA Contact: sunzhaohua <zhsun>
Status: CLOSED ERRATA Docs Contact:
Severity: high    
Priority: high CC: aos-bugs
Version: 4.9   
Target Milestone: ---   
Target Release: 4.10.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 2066270 (view as bug list) Environment:
Last Closed: 2022-03-28 12:03:54 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2066270    

Description Alberto 2022-03-21 11:27:12 UTC
This https://github.com/openshift/kubernetes-autoscaler/pull/214 enabled upstream capi support in openshift 4.10 autoscaler fork which was referencing old annotations.
The same is needed in 4.9 so It can be used by HyperShift when running 4.9 HostedClusters

Comment 1 Joel Speed 2022-03-21 11:59:04 UTC
This PR merged a while ago, needs to be verified by QE so that we can backport it

Comment 3 sunzhaohua 2022-03-24 07:45:03 UTC
Verified
clusterversion: 4.10.0-0.nightly-2022-03-23-153617
Steps:
1. Install ocp cluster
2. Create a HostedCluster
3. Add NodePools and enable autoscaling
$ oc get nodepools -n clusters                                                                                                                                                                           
NAME                    CLUSTER      DESIRED NODES   CURRENT NODES   AUTOSCALING   AUTOREPAIR   VERSION   UPDATINGVERSION   UPDATINGCONFIG   MESSAGE
example-02-us-east-2a   example-02                                   True          False                  True              True             Minimum availability requires 2 replicas, current 0 available
example-04-us-east-2a   example-04                                   True          False        4.10.6                                       Minimum availability requires 1 replicas, current 0 available
4. Check machineset annotation is cluster.x-k8s.io/cluster-api-autoscaler-node-group-max-size
$ oc edit machinesets.cluster.x-k8s.io -n clusters-example-04
metadata:
  annotations:
    cluster.x-k8s.io/cluster-api-autoscaler-node-group-max-size: "5"
    cluster.x-k8s.io/cluster-api-autoscaler-node-group-min-size: "1"
    hypershift.openshift.io/nodePool: clusters/example-04-us-east-2a

Comment 5 errata-xmlrpc 2022-03-28 12:03:54 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.10.6 bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:1026