Bug 2066623

Summary: Drop dependency on python-dateutil
Product: [oVirt] ovirt-hosted-engine-setup Reporter: Asaf Rachmani <arachman>
Component: GeneralAssignee: Yedidyah Bar David <didi>
Status: CLOSED CURRENTRELEASE QA Contact: Sandro Bonazzola <sbonazzo>
Severity: high Docs Contact:
Priority: high    
Version: 2.6.1CC: bugs, didi, lsurette, mhicks, srevivo, stirabos
Target Milestone: ovirt-4.5.0Keywords: CodeChange, VerifiedUpstream, ZStream
Target Release: ---Flags: sbonazzo: ovirt-4.5+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-03-28 10:00:40 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Integration RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2065052    

Description Asaf Rachmani 2022-03-22 08:01:56 UTC
ansible-core-2.12 requires all libraries used in Ansible modules/roles/playbooks to be built with Python 3.8, so we need to build and distribute python38-dateutil in RHV channels, because it's a dependency for ovirt-hosted-engine-setup, where we use ansible callbacks executed within ansible-core-2.12

Comment 1 Yedidyah Bar David 2022-03-28 10:00:40 UTC
AFAIU the only user of dateutil was ovirt-hosted-engine-setup. With [1], it does not use it anymore. Closing.

[1] https://github.com/oVirt/ovirt-hosted-engine-setup/commit/00cf2690739e98772bf3c827e33ec0313baf5888

Comment 2 Yedidyah Bar David 2022-03-28 11:53:21 UTC
Mind you, this isn't purely a CodeChange. It does have the slight (IMO) disadvantage that the timezone offset is calculated only once, at ansible-playbook run start. So if you start it slightly before an offset change (e.g. from daylight saving time to standard time or vice verse), the log file will be wrong since the offset change onwards - will show the same offset instead of the updated one. But I think it's worth it.

Comment 3 Yedidyah Bar David 2022-03-28 11:58:50 UTC
("it", in "start it", isn't the full deployment, but a specific playbook. 'hosted-engine --deploy' has its own log file, which should be correct (it requires and uses python36-dateutil), and runs several invocations of ansible-playbook).

Comment 4 Sandro Bonazzola 2022-04-20 06:32:24 UTC
This bugzilla is included in oVirt 4.5.0 release, published on April 20th 2022.

Since the problem described in this bug report should be resolved in oVirt 4.5.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.