Bug 2066876

Summary: storage - support for creating and managing LVM thin pools/LVs
Product: Red Hat Enterprise Linux 8 Reporter: Rich Megginson <rmeggins>
Component: rhel-system-rolesAssignee: Rich Megginson <rmeggins>
Status: CLOSED ERRATA QA Contact: guazhang <guazhang>
Severity: unspecified Docs Contact: Gabi Fialová <gfialova>
Priority: unspecified    
Version: 8.7CC: djez, gfialova, nhosoi, spetrosi, vtrefny, yizhan
Target Milestone: rcKeywords: Triaged
Target Release: 8.7   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: role:storage
Fixed In Version: rhel-system-roles-1.19.1-1.el8 Doc Type: Enhancement
Doc Text:
.Support for thinly provisioned volumes is available in the `storage` RHEL System Role The `storage` RHEL System Role can now create and manage thinly provisioned LVM logical volumes. Thin provisioned LVs are allocated as they are written, allowing better flexibility when creating volumes as physical storage provided for thin provisioned LVs can be increased later as the need arises. LVM thin provisioning also allows creating more efficient snapshots because the data blocks common to a thin LV and any of its snapshots are shared.
 Story Points: ---
Clone Of:
: 2072745 (view as bug list) Environment:
Last Closed: 2022-11-08 09:40:52 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2072745    

Description Rich Megginson 2022-03-22 16:35:13 UTC 
Description of problem:
The storage role should be able to create and manage LVM thin pools/LV's

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 1 Rich Megginson 2022-04-25 22:29:09 UTC 
Any updates?
Comment 4 guazhang@redhat.com 2022-06-07 09:12:50 UTC 
Hi


Test the http://brew-task-repos.usersys.redhat.com/repos/scratch/rmeggins/rhel-system-roles/1.19.0/1.el8/noarch/rhel-system-roles-1.19.0-1.el8.noarch.rpm

test pass with tests_create_thinp_then_remove.yml.

but found a error with the cmd ansible-playbook -vv -i host tests_luks_nvme_generated.yml

TASK [rhel-system-roles.storage : manage the pools and volumes to match the specified state] ***
task path: /usr/share/ansible/roles/rhel-system-roles.storage/tasks/main-blivet.yml:77
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: AttributeError: 'DiskLabel' object has no attribute 'label'
fatal: [localhost]: FAILED! => {"changed": false, "module_stderr": "Traceback (most recent call last):\n  File \"/root/.ansible/tmp/ansible-tmp-1654587989.5256016-199566-171949464017407/AnsiballZ_blivet.py\", line 100, in <module>\n    _ansiballz_main()\n  File \"/root/.ansible/tmp/ansible-tmp-1654587989.5256016-199566-171949464017407/AnsiballZ_blivet.py\", line 92, in _ansiballz_main\n    invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)\n  File \"/root/.ansible/tmp/ansible-tmp-1654587989.5256016-199566-171949464017407/AnsiballZ_blivet.py\", line 41, in invoke_module\n    run_name='__main__', alter_sys=True)\n  File \"/usr/lib64/python3.6/runpy.py\", line 205, in run_module\n    return _run_module_code(code, init_globals, run_name, mod_spec)\n  File \"/usr/lib64/python3.6/runpy.py\", line 96, in _run_module_code\n    mod_name, mod_spec, pkg_name, script_name)\n  File \"/usr/lib64/python3.6/runpy.py\", line 85, in _run_code\n    exec(code, run_globals)\n  File \"/tmp/ansible_blivet_payload_14xsyew5/ansible_blivet_payload.zip/ansible/modules/blivet.py\", line 1840, in <module>\n  File \"/tmp/ansible_blivet_payload_14xsyew5/ansible_blivet_payload.zip/ansible/modules/blivet.py\", line 1836, in main\n  File \"/tmp/ansible_blivet_payload_14xsyew5/ansible_blivet_payload.zip/ansible/modules/blivet.py\", line 1798, in run_module\n  File \"/tmp/ansible_blivet_payload_14xsyew5/ansible_blivet_payload.zip/ansible/modules/blivet.py\", line 1431, in manage_volume\n  File \"/tmp/ansible_blivet_payload_14xsyew5/ansible_blivet_payload.zip/ansible/modules/blivet.py\", line 560, in manage\n  File \"/tmp/ansible_blivet_payload_14xsyew5/ansible_blivet_payload.zip/ansible/modules/blivet.py\", line 609, in _create\n  File \"/tmp/ansible_blivet_payload_14xsyew5/ansible_blivet_payload.zip/ansible/modules/blivet.py\", line 531, in _reformat\nAttributeError: 'DiskLabel' object has no attribute 'label'\n", "module_stdout": "", "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error", "rc": 1}
Comment 5 Rich Megginson 2022-06-07 14:10:23 UTC 
(In reply to guazhang from comment #4)
> Hi
> 
> 
> Test the
> http://brew-task-repos.usersys.redhat.com/repos/scratch/rmeggins/rhel-system-
> roles/1.19.0/1.el8/noarch/rhel-system-roles-1.19.0-1.el8.noarch.rpm
> 
> test pass with tests_create_thinp_then_remove.yml.
> 
> but found a error with the cmd ansible-playbook -vv -i host
> tests_luks_nvme_generated.yml
> 
> TASK [rhel-system-roles.storage : manage the pools and volumes to match the
> specified state] ***
> task path:
> /usr/share/ansible/roles/rhel-system-roles.storage/tasks/main-blivet.yml:77
> An exception occurred during task execution. To see the full traceback, use
> -vvv. The error was: AttributeError: 'DiskLabel' object has no attribute
> 'label'
> fatal: [localhost]: FAILED! => {"changed": false, "module_stderr":
> "Traceback (most recent call last):\n  File
> \"/root/.ansible/tmp/ansible-tmp-1654587989.5256016-199566-171949464017407/
> AnsiballZ_blivet.py\", line 100, in <module>\n    _ansiballz_main()\n  File
> \"/root/.ansible/tmp/ansible-tmp-1654587989.5256016-199566-171949464017407/
> AnsiballZ_blivet.py\", line 92, in _ansiballz_main\n   
> invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)\n  File
> \"/root/.ansible/tmp/ansible-tmp-1654587989.5256016-199566-171949464017407/
> AnsiballZ_blivet.py\", line 41, in invoke_module\n    run_name='__main__',
> alter_sys=True)\n  File \"/usr/lib64/python3.6/runpy.py\", line 205, in
> run_module\n    return _run_module_code(code, init_globals, run_name,
> mod_spec)\n  File \"/usr/lib64/python3.6/runpy.py\", line 96, in
> _run_module_code\n    mod_name, mod_spec, pkg_name, script_name)\n  File
> \"/usr/lib64/python3.6/runpy.py\", line 85, in _run_code\n    exec(code,
> run_globals)\n  File
> \"/tmp/ansible_blivet_payload_14xsyew5/ansible_blivet_payload.zip/ansible/
> modules/blivet.py\", line 1840, in <module>\n  File
> \"/tmp/ansible_blivet_payload_14xsyew5/ansible_blivet_payload.zip/ansible/
> modules/blivet.py\", line 1836, in main\n  File
> \"/tmp/ansible_blivet_payload_14xsyew5/ansible_blivet_payload.zip/ansible/
> modules/blivet.py\", line 1798, in run_module\n  File
> \"/tmp/ansible_blivet_payload_14xsyew5/ansible_blivet_payload.zip/ansible/
> modules/blivet.py\", line 1431, in manage_volume\n  File
> \"/tmp/ansible_blivet_payload_14xsyew5/ansible_blivet_payload.zip/ansible/
> modules/blivet.py\", line 560, in manage\n  File
> \"/tmp/ansible_blivet_payload_14xsyew5/ansible_blivet_payload.zip/ansible/
> modules/blivet.py\", line 609, in _create\n  File
> \"/tmp/ansible_blivet_payload_14xsyew5/ansible_blivet_payload.zip/ansible/
> modules/blivet.py\", line 531, in _reformat\nAttributeError: 'DiskLabel'
> object has no attribute 'label'\n", "module_stdout": "", "msg": "MODULE
> FAILURE\nSee stdout/stderr for the exact error", "rc": 1}

This sure looks like a duplicate, or at least related to, https://bugzilla.redhat.com/show_bug.cgi?id=2059426 - @vtrefny ?

At any rate, can we mark this bz as qa_ack+ and Verified:Tested as the issue above is completely different and unrelated to the BZ?
Comment 6 Vojtech Trefny 2022-06-09 08:06:08 UTC 
(In reply to Rich Megginson from comment #5)
> (In reply to guazhang from comment #4)
> 
> This sure looks like a duplicate, or at least related to,
> https://bugzilla.redhat.com/show_bug.cgi?id=2059426 - @vtrefny ?
> 

Yes, this look likes the same issue.
Comment 11 guazhang@redhat.com 2022-07-06 12:52:39 UTC 
move to verified since the storage role regression test pass
Comment 13 errata-xmlrpc 2022-11-08 09:40:52 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (rhel-system-roles bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2022:7568