Bug 206708

Summary: Review Request: acerhk - Acer Hotkey driver
Product: [Fedora] Fedora Reporter: Marcin Grabda <grabka1983>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED NOTABUG QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: kevin, kwizart, s.adam
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-06-09 22:45:24 EDT Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On:    
Bug Blocks: 201449    

Description Marcin Grabda 2006-09-15 16:05:44 EDT
Spec URL: http://student.agh.edu.pl/~grabka/acerhk/acerhk.spec
SRPM URL: http://student.agh.edu.pl/~grabka/acerhk/acerhk.spec
Description: This package contains the driver for managing special buttons and wireless
antenna on Acer and compatible laptops.
Comment 1 Stewart Adam 2006-09-21 18:11:34 EDT
I'm not a reviewer, but I can do what I can to help.

rpmlint on both the binary (for i686 at least) and SRPMS comes out clean, and
they build flawlessly on my machine. I have no complaints here, you have a
pretty clean package!
Comment 2 Nicolas Chauvet (kwizart) 2006-10-17 20:31:45 EDT
Need to be added since kernel 2.6.18-1.2200.fc5, because like many kmod-package
- including of linux/config.h now is deprecated. (i've pick a recent example
from Ville Skyttä)

%prep
Setup ...
grep -rlF '<linux/config.h>' acerhk-%{version} \
| xargs sed -i -e 's|<linux/config.h>|<linux/autoconf.h>|' 

Any idea when this package will be accepted on extras?
Comment 3 Kevin Fenzi 2007-06-02 23:37:31 EDT
Same note as for the acerhk-kmod submission: 

Marcin: Do you still wish to submit this package? 
If I don't hear anything from you in 1 week I will go ahead and close it. 

NOTE: from what I can see on the upstream page, this driver is no longer being
maintained... 

"Unfortunately I have not the time anymore to actively support this driver, I
even don't own an Acer laptop anymore. If anyone is interested to take over the
job of maintaining this driver, please contact me.

You can still mail me, I will try to help you, but it will take some time and I
am not always able to give help."

(from: http://www.cakey.de/acerhk/)
Comment 4 Kevin Fenzi 2007-06-09 22:45:24 EDT
Marcin: I am going to go ahead and close this now. 

If you want to continue, feel free to re-open this review or file a new one.