Bug 206837
Summary: | Review Request: python-turbocheetah - TurboGears plugin to support use of Cheetah templates | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Luke Macken <lmacken> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | dcallagh, j, pfrields |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-10-10 15:21:55 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779, 189338 |
Description
Luke Macken
2006-09-17 05:22:37 UTC
http://people.redhat.com/lmacken/SPECS/python-turbocheetah.spec http://people.redhat.com/lmacken/RPMS/python-turbocheetah-0.9.5-2.src.rpm * Sat Sep 30 2006 Luke Macken <lmacken> - 0.9.5-2 - Rename to python-turbocheetah - Install egg-info - Add README This failed to build for me in mock: Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.30074 [...] + /usr/bin/python setup.py build Traceback (most recent call last): File "setup.py", line 1, in ? from setuptools import setup, find_packages ImportError: No module named setuptools error: Bad exit status from /var/tmp/rpm-tmp.30074 (%build) Adding a BR: python-setuptools gets things building. rpmlint only says: W: python-turbocheetah mixed-use-of-spaces-and-tabs (spaces: line 6, tab: line 18) Is it actually possible to run any of those tests, or do they just clutter things up needlessly? The script in the tests directory doesn't even have a main method, so they're pretty much just adding clutter, so I removed them. http://people.redhat.com/lmacken/RPMS/python-turbocheetah-0.9.5-3.src.rpm http://people.redhat.com/lmacken/SPECS/python-turbocheetah.spec * Fri Oct 6 2006 Luke Macken <lmacken> - 0.9.5-3 - Add python-setuptools to BuildRequires - Remove tests directory Oops, I guess I took too long to get back to this, because 0.9.5 is now unavailable. At least, when I try to fetch the source, I'm redirected to a page that tells me that the preview is over. But I don't actually see a place to download TurboCheetah separately, except as eggs. Ah, the Source0 in the spec is wrong (I'll fix it up for the next revision). I pulled down the tarballs for 0.9.5 from the Cheese Shop: http://cheeseshop.python.org/pypi/TurboCheetah Ah, OK. I changed Source0 to http://cheeseshop.python.org/packages/source/T/TurboCheetah/TurboCheetah-%{version}.tar.gz The one remaining issue I see is that this package needs to own /usr/lib/python2.4/site-packages/turbocheetah. * source files match upstream: 52e12130302a218a8e3b925447041be4 TurboCheetah-0.9.5.tar.gz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: python-turbocheetah = 0.9.5-3.fc6 = python(abi) = 2.4 python-cheetah >= 1.0 * %check is not present; tests not runnable. X needs to own /usr/lib/python2.4/site-packages/turbocheetah * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. http://people.redhat.com/lmacken/RPMS/python-turbocheetah-0.9.5-4.src.rpm http://people.redhat.com/lmacken/SPECS/python-turbocheetah.spec * Tue Oct 10 2006 Luke Macken <lmacken> - 0.9.5-4 - Fix Source0 - Own %%{python_sitelib}/turbocheetah Looks good now. APPROVED I'll try to get to the other package ASAP. Imported into CVS, added to owners.list, FC-5 branch requested, tagged and built for devel. Thanks! Changing the summary for tracking purposes. Please un-retire the epel7 branch. Package Change Request ====================== Package Name: python-turbocheetah New Branches: epel7 Owners: dcallagh Complete. |