Bug 2068492
| Summary: | Review Request: fedora-appstream-metadata - Operating System AppStream Metadata for Fedora Linux | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Timothée Ravier <travier> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | ejgoqvmerramxovrne, ngompa13, package-review |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-06-22 18:19:30 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Timothée Ravier
2022-03-25 13:48:39 UTC
See https://src.fedoraproject.org/rpms/fedora-release/pull-request/217 for more context. This enables applications (such as Discover) to figure out which releases are still supported and display information to the user if they are using and EOL release. See: https://www.freedesktop.org/software/appstream/docs/sect-Metadata-OS.html The "full" source is at https://github.com/travier/fedora-appstream-metadata. This includes the script used to automatically generate/update the metadata. Taking this review. Can you please include the source and generate the appstream file in the package spec? Maybe I'm missing something, but I think that I can't generate the appstream file during a build step in the specfile as this needs network access. I was planning on adding the Go "script" to the dist-git repo after the initial import as it's not really a source for the RPM itself. Hmm, I would prefer the source to be part of the SRPM, but yeah that makes sense why you can't run the generation process during the build. Can I add files and not use them? If yes then I can definitely add it to the SRPM. I would prefer not to build/install it as nobody would really us it. (In reply to Timothée Ravier from comment #7) > Can I add files and not use them? If yes then I can definitely add it to the > SRPM. I would prefer not to build/install it as nobody would really us it. Yes. Updated SRPM & spec file: Spec URL: https://siosm.fedorapeople.org/srpms/fedora-appstream-metadata.spec SRPM URL: https://siosm.fedorapeople.org/srpms/fedora-appstream-metadata-37-0.2.fc37.src.rpm You're missing a license file. Everything is MIT and explicitly marked in source code or the files themselves. Should I include the MIT LICENSE file in the SRPM? Found the relevant portion in the docs. I'll do that. Updated SRPM & spec file: Spec URL: https://siosm.fedorapeople.org/srpms/fedora-appstream-metadata.spec SRPM URL: https://siosm.fedorapeople.org/srpms/fedora-appstream-metadata-37-0.3.fc37.src.rpm Review notes: * Package is named appropriately * Package builds and installs * Package licensing is correct and license file is installed * No serious issues with rpmlint PACKAGE APPROVED. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/fedora-appstream-metadata FEDORA-2022-8bf70217cf has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-8bf70217cf FEDORA-2022-8bf70217cf has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-4bb9a0f4de has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-4bb9a0f4de FEDORA-2022-4bb9a0f4de has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. |