Bug 2069258

Summary:	Git import detection does not happen for private repositories
Product:	OpenShift Container Platform	Reporter:	Mohammed Saud <msaud>
Component:	Dev Console	Assignee:	Mohammed Saud <msaud>
Status:	CLOSED ERRATA	QA Contact:	spathak <spathak>
Severity:	high	Docs Contact:	shipra singh <shipsing>
Priority:	high
Version:	4.9	CC:	aos-bugs, cbremble, cjerolim, cvogt, nmukherj, oarribas, openshift-bugzilla-robot, roarora, scuppett, sdoyle, spathak, viraj
Target Milestone:	---	Flags:	cvogt: needinfo-
Target Release:	4.9.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	Before this update, if users provided a secret for a private repository in the Import from Git form, the secret was not decoded. As a result, the Import from Git form failed to detect the correct import strategy and builder image for the repository. With this update, the Import from Git form decodes the secret before its use, which helps detect the correct import strategy and builder image. (BZ#2069258)	Story Points:	---
Clone Of:	2057507	Environment:
Last Closed:	2022-05-03 07:35:33 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2057507
Bug Blocks:

Comment 3 Christoph Jerolimov 2022-04-25 15:17:40 UTC

Tested this on 4.9.0-0.nightly-2022-04-22-094022

Imported a private git repo from GitHub with a personal access token as secret (username was empty, password the PAT)

Comment 8 errata-xmlrpc 2022-05-03 07:35:33 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.9.31 bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:1605

Comment 9 shipra singh 2022-08-09 06:24:07 UTC

@msaud,@spathak: Could you please help with review of the following content that needs to go in here: https://docs.openshift.com/container-platform/4.9/release_notes/ocp-4-9-release-notes.html#ocp-4-9-31 for this issue: https://issues.redhat.com/browse/RHDEVDOCS-4274

The Bug Fix description for review:

Previously, when users would provide a secret for a private repository in the Git import form, the value of the secret was not decoded. As a result, the Git import form failed to detect the correct import strategy and builder image for the repository.  With this fix, the Git import form decodes the value of the secret before its use, which helps identification of the correct import strategy and builder image. (BZ#2069258)
 
Thanks

Comment 10 Mohammed Saud 2022-08-09 09:36:47 UTC

Thanks, doc text looks good to me.

Comment 11 shipra singh 2022-08-09 11:30:29 UTC

@spathak, could you please review the content in the doc text field and provide an ack from your side?

Comment 12 spathak@redhat.com 2022-08-10 05:54:14 UTC

Thanks, looks good to me