Bug 2069453
Summary: | Review Request: SDL2_sound - An abstract soundfile decoder library | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Dominik 'Rathann' Mierzejewski <dominik> |
Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | hdegoede, ngompa13, package-review |
Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2022-05-07 04:17:01 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1947732 |
Description
Dominik 'Rathann' Mierzejewski
2022-03-28 22:16:24 UTC
Taking this review. Thanks! Here's the correct link for the SRPM: Spec URL: https://rathann.fedorapeople.org/review/SDL2_sound/SDL2_sound.spec SRPM URL: https://rathann.fedorapeople.org/review/SDL2_sound/SDL2_sound-2.0.1-1.fc36.src.rpm *** Bug 2068687 has been marked as a duplicate of this bug. *** Neal, thank you for reviewing this. I also volunteered to review this here: https://src.fedoraproject.org/rpms/SDL_sound/pull-request/1 But I'm happy for you to do it :) Let me know if you need any help. > %files
> %license LICENSE.txt
> %doc docs/CREDITS.txt docs/README.txt
> %{_bindir}/playsound
> %{_libdir}/libSDL2_sound.so.2{,.*}
Can you please split out playsound into a subpackage so that this is multilib safe?
(In reply to Neal Gompa from comment #5) > > %files > > %license LICENSE.txt > > %doc docs/CREDITS.txt docs/README.txt > > %{_bindir}/playsound > > %{_libdir}/libSDL2_sound.so.2{,.*} > > Can you please split out playsound into a subpackage so that this is > multilib safe? rpm uses file-coloring, so it is allowed to have /usr/bin/foo in both the i686 and x86_64 package and to install both at the same time; and it is tiny. I do see that the SDL1 SDL_sound package also installs a /usr/bin/playsound, which actually is a problem. Maybe rename the SDL2 one to playsound2? Or given that the SDL_sound (v1) version is obsolete submit a PR to rename that one out of the way? (In reply to Hans de Goede from comment #6) > (In reply to Neal Gompa from comment #5) > > > %files > > > %license LICENSE.txt > > > %doc docs/CREDITS.txt docs/README.txt > > > %{_bindir}/playsound > > > %{_libdir}/libSDL2_sound.so.2{,.*} > > > > Can you please split out playsound into a subpackage so that this is > > multilib safe? > > rpm uses file-coloring, so it is allowed to have /usr/bin/foo in both the > i686 and x86_64 package and to install both at the same time; and it is tiny. > > I do see that the SDL1 SDL_sound package also installs a /usr/bin/playsound, > which actually is a problem. Maybe rename the SDL2 one to playsound2? Or > given that the SDL_sound (v1) version is obsolete submit a PR to rename that > one out of the way? Maybe instead just remove the binary from SDL_sound, since this effectively replaces that. > Maybe instead just remove the binary from SDL_sound, since this effectively replaces that.
Yes that would be fine too.
Review notes: * Packaging complies with the guidelines * Package builds and installs * No serious issues from rpmlint * Licensing is correct and license files are correctly installed PACKAGE APPROVED. Please adjust SDL_sound to drop the conflicting binaries. Ok, I'll prepare updated SDL_sound packages for F35+ dropping the play_sound util. Note I plan to _not_ create bodhi updates for these, the idea being that these will get added to the bodhi update with the new SDL2_sound pkg once those have been build, so please don't forget to add them :) Let me know if you need the SDL_sound update for any other branches too. > Ok, I'll prepare updated SDL_sound packages for F35+ dropping the play_sound util.
Done.
Thanks a lot, Hans. That's really helpful. I'll add the builds to SDL2_sound newpackage update. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/SDL2_sound FEDORA-2022-4cfb2ca145 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-4cfb2ca145 FEDORA-2022-4cfb2ca145 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-4cfb2ca145 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-4cfb2ca145 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-4cfb2ca145 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. |