Bug 2070097

Summary:	net_id builtin shouldn't fallback to PCI path based names if non-conflicting hotplug slot based names can be generated
Product:	Red Hat Enterprise Linux 9	Reporter:	Michal Sekletar <msekleta>
Component:	systemd	Assignee:	Michal Sekletar <msekleta>
Status:	CLOSED ERRATA	QA Contact:	Frantisek Sumsal <fsumsal>
Severity:	urgent	Docs Contact:
Priority:	unspecified
Version:	9.0	CC:	dtardon, pvlasin, systemd-maint-list, systemd-maint, yuma
Target Milestone:	rc	Keywords:	Improvement, Triaged
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	systemd-250-6.el9_0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	2073003 (view as bug list)		Environment:
Last Closed:	2022-05-17 15:57:38 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2073003
Deadline:	2022-04-11

Description Michal Sekletar 2022-03-30 12:17:44 UTC

Description of problem:
In net_id we are now trying to avoid naming conflict for network devices which have PCI hotplug slot associated with the parent PCI bridge. This was introduced in, https://github.com/systemd/systemd/commit/2c8ec0095e6fd2e72879d4915ff8a9e5c0664d0b and it is correct behaviour for devices which share single PCI function. However, for multifunction devices it is not necessary to avoid slot based naming because there won't be any conflict to begin as function number will be appended after slot number and resulting interface names will be e.g. ens1f1, ens1f2.

Version-Release number of selected component (if applicable):
systemd-250-5.el9_0

How reproducible:
deterministic

Steps to Reproduce:
1. Boot RHEL-9 on system which has multiport, multifunction NIC installed in PCI-e hotplug slot (i.e. not integrated on the motherboard).

Actual results:
Interface names assigned to the interfaces will be based on PCI topology, e.g. enp59s0f0np0 enp59s0f1np1.

Expected results:
Slot based names are used if possible, e.g. ens1f0np0, ens1f1np1.

Additional info:
https://github.com/systemd/systemd/pull/22844

System which can be used for testing is dell-per740-06.rhts.eng.pek2.redhat.com.

Comment 8 Plumber Bot 2022-04-07 12:57:49 UTC

fix merged to github rhel-9.0.0 branch -> https://github.com/redhat-plumbers/systemd-rhel9/pull/79

Comment 11 errata-xmlrpc 2022-05-17 15:57:38 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (new packages: systemd), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:3979