Bug 2070136

Summary:	[4.9.z] Custom guest PCI address and boot order parameters are not respected in a list of multiple SR-IOV NICs
Product:	Container Native Virtualization (CNV)	Reporter:	Petr Horáček <phoracek>
Component:	Networking	Assignee:	Orel Misan <omisan>
Status:	CLOSED NOTABUG	QA Contact:	Ruth Netser <rnetser>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	4.9.0	CC:	cnv-qe-bugs, omisan, phoracek, rnetser
Target Milestone:	---
Target Release:	4.9.5
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	2070050	Environment:
Last Closed:	2022-04-07 08:45:29 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2070050
Bug Blocks:

Description Petr Horáček 2022-03-30 13:23:08 UTC

+++ This bug was initially created as a clone of Bug #2070050 +++

Description of problem:
On a VMI object that has a list of multiple SR-IOV NICs, the pciAddress and bootOrder parameters of the last item in the list - are applied to all other elements of the list.

The VMI object passes the validation in the virt-api webhooks.

The virt-launcher fails because there are allegedly several host devices (the SR-IOV NICs) with the same required guest PCI addresses:
"message: 'server error. command SyncVMI failed: "LibvirtError(Code=27, Domain=20, Message=''XML error: Attempted double use of PCI Address 0000:82:00.0'')"'"

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Create a VMI object with at least two SR-IOV NICs, that has custom guest PCI address.
2. Apply the VMI manifest.

Actual results:
The virt-launcher fails because there are allegedly several host devices (the SR-IOV NICs) with the same required guest PCI addresses.

Expected results:
A VM should start with the number of specified SR-IOV NICs that have the required PCI addresses.

Additional info:

Comment 1 Petr Horáček 2022-04-07 08:32:32 UTC

We should have a fix backported once https://github.com/kubevirt/kubevirt/pull/7482#issuecomment-1091307737 gets addressed

Comment 2 Petr Horáček 2022-04-07 08:45:29 UTC

The bug was introduced only in release-0.45. Since 4.9 is based on release-0.44, this BZ can be closed