Bug 2070181

Summary:	[MAPO] serverGroupName ignored
Product:	OpenShift Container Platform	Reporter:	Michał Dulko <mdulko>
Component:	Cloud Compute	Assignee:	Michał Dulko <mdulko>
Cloud Compute sub component:	OpenStack Provider	QA Contact:	Itay Matza <imatza>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	high
Priority:	urgent	CC:	aos-bugs, imatza, m.andre, mfedosin, pprinett
Version:	4.11	Keywords:	TestBlocker, Triaged
Target Milestone:	---
Target Release:	4.11.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-08-10 11:02:42 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Michał Dulko 2022-03-30 14:52:17 UTC

Description of problem:
In downstream CAPO we've supported serverGroupName field on Machine. This seems to be missing from MAPO and only serverGroupID is taken into account.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 5 Itay Matza 2022-04-12 13:36:38 UTC

Verified with OCP 4.11.0-0.nightly-2022-04-08-205307 on top of RHOS-16.1-RHEL-8-20220329.n.1 with Kuryr.
(MAPO is the default for OpenStack deployments on this version)

Verification steps:
1) Configure a workers machineset with anti-affinity and use the serverGroupName:
```
$ openstack server group list
+--------------------------------------+---------------------+---------------+
| ID                                   | Name                | Policy        |
+--------------------------------------+---------------------+---------------+
| e60890ae-66a6-4d77-9006-f542b740eb72 | ostest-xs74z-master | anti-affinity |
| aa2ea97d-8fbf-4569-ba58-865ffa418789 | ostest-xs74z-worker | anti-affinity |
+--------------------------------------+---------------------+---------------+
$ oc get machinesets -A                                                                                                                                                        
NAMESPACE               NAME                    DESIRED   CURRENT   READY   AVAILABLE   AGE
openshift-machine-api   ostest-xs74z-worker-0   2         2         2       2           3h4m
$ oc get machinesets -n openshift-machine-api ostest-xs74z-worker-0 -o yaml | grep serverGroupName
          serverGroupName: ostest-xs74z-worker
```
2) The server group tests in openstack-test are passing:
```
passed: (2.9s) 2022-04-11T13:03:23 "[sig-installer][Feature:openstack] The OpenStack platform creates Worker nodes in a server group [Suite:openshift/conformance/parallel]"
passed: (3.2s) 2022-04-11T13:03:24 "[sig-installer][Feature:openstack] The OpenStack platform creates Control plane nodes in a server group [Suite:openshift/conformance/parallel]"

```

Comment 8 errata-xmlrpc 2022-08-10 11:02:42 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Container Platform 4.11.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5069