Bug 207075

Summary: Typo in /etc/init.d/irqbalance makes irqbalance start at every runlevel change
Product: [Fedora] Fedora Reporter: Philippe Troin <phil>
Component: irqbalanceAssignee: Neil Horman <nhorman>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 5   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 1.2-1.26 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-09-19 12:13:00 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Philippe Troin 2006-09-19 05:51:43 UTC 
irqbalance-1.12-1.25

/etc/init.d/irqbalance says:

start() {
        echo -n $"Starting $prog: "
        daemon irqbalance $ONESHOT
        RETVAL=$?
        echo
        [ $RETVAL -eq 0 -a -n "$ONESHOT" ] && touch /var/lock/subsys/irqbalance
        return $RETVAL
}

If ONESHOT is empty, -n "$ONESHOT" is false, and /var/lock/subsys/irqbalance is
never touched.

This causes irqbalance to get started every time one changes the runlevel. 
Hopefully, only one irqbalance process runs, because the pid file is checked.
Nevertheless, it's broken.

It should be:

        [ $RETVAL -eq 0 -a -z "$ONESHOT" ] && touch /var/lock/subsys/irqbalance

Phil.
Comment 1 Neil Horman 2006-09-19 12:13:00 UTC 
fixed in -1.26