Bug 207082
| Summary: | Review Request: perl-Feed-Find - Syndication feed auto-discovery | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Patrice Dumas <pertusus> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | ||
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-09-24 11:22:44 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Patrice Dumas
2006-09-19 08:01:29 UTC
This fails to build for me: t/01-find....... # Failed test in t/01-find.t at line 13. # got: '0' # expected: '1' # Failed test in t/01-find.t at line 14. # got: undef # expected: 'http://stupidfool.org/perl/feeds/ok.xml' # Failed test in t/01-find.t at line 20. # got: '0' # expected: '1' # Failed test in t/01-find.t at line 21. # got: undef # expected: 'http://stupidfool.org/perl/feeds/ok.xml' # Looks like you failed 4 tests of 4. dubious Test returned status 4 (wstat 1024, 0x400) DIED. FAILED tests 1-4 Failed 4/4 tests, 0.00% okay Failed Test Stat Wstat Total Fail Failed List of Failed ------------------------------------------------------------------------------- t/01-find.t 4 1024 4 4 100.00% 1-4 Failed 1/2 test scripts, 50.00% okay. 4/5 subtests failed, 20.00% okay. I doubt this test will ever work in mock. I think you need "rm t/01-find.t" in %check (or in %prep if you want to avoid a complaint about a missing test) with suitable comments to indicate why it's being disabled. That done, things build OK. I'll assume that change is done for the purposes of this review. * source files match upstream: be4537f652d41243cbf98f5e937d16f3 Feed-Find-0.06.tar.gz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * latest version is being packaged. O BuildRequires are proper (BR: perl is unnecessary, and perl(LWP::UserAgent) is redundant). * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: perl(Feed::Find) = 0.06 perl-Feed-Find = 0.06-1.fc6 = perl(:MODULE_COMPAT_5.8.8) perl(Class::ErrorHandler) perl(HTML::Parser) perl(LWP::UserAgent) perl(URI) perl(base) perl(constant) perl(strict) perl(vars) * %check is present and all tests pass: All tests successful. Files=1, Tests=1, 0 wallclock secs ( 0.04 cusr + 0.01 csys = 0.05 CPU) * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED, provided the non-runnable test is removed so that things build in mock. Thanks for the review. I imported in cvs after removing the test in %prep. It built in devel. |