Bug 2070860

Hi Carmelo,

Thanks for the effort, and overall a good package! I see a couple of things to tweak before it's approvable:

1. For future request, please provide direct links and not links that require clicking around for both SRPM and SPEC files
2. The Summary is too long. The maximum length is 79 chars.
3. The shipped binary (makeset) only utility is to generate the source code, so we do not need to have it within the package, since we are already ship the output of it.

To strip the binary you should:
* Add the configuration to let the builder know to produce platform-independent RPM, since we are only going to ship sources:

    BuildArch:      noarch

* Remove the build of the binary:

    for cmd in makeset; do
      %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd
    done

* Remove the installation of the binary and respective folder:

    install -m 0755 -vd                     %{buildroot}%{_bindir}
    install -m 0755 -vp %{gobuilddir}/bin/* %{buildroot}%{_bindir}/

* Since we only need to put files in the -devel package, we can also remove the whole %file block since %gopkgfiles will take care of all files and put them in the right location without help:

    %files devel
    %license LICENSE
    %doc README.md
    %{_bindir}/*

Thank you Fale for your comment.
I followed your instructions and pushed the modified .spec and srpm files in the same repo.

Spec URL: https://raw.githubusercontent.com/Laiot/golang-bitbucket-creachadair-stringset-rpm/master/golang-bitbucket-creachadair-stringset.spec
SRPM URL: https://github.com/Laiot/golang-bitbucket-creachadair-stringset-rpm/blob/master/golang-bitbucket-creachadair-stringset-0.0.10-1.20220331git1f9a78a.fc36.src.rpm
Description: A lightweight set-of-strings implementation based on the Go built-in map type.
Fedora Account System Username: laiot

go2rpm package, fedora-review is correct:

- The specfile is sane.
- License is correct
- Builds successfully in mock
- No rpmlint errors
- %check section passes
- The latest version is packaged
- The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- Add package to release-monitoring.org
- Add package to Koschei.
- Give go-sig privileges on package
- Close the review bug by referencing it in the rpm changelog and/or the Bodhi ticket.

Thanks!

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-bitbucket-creachadair-stringset