Bug 2071134
| Summary: | simpledrm makes a regresion with non normal oriented panels ouput | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | David Santamaría Rogado <howl.nsp> |
| Component: | kernel | Assignee: | Kernel Maintainer List <kernel-maint> |
| Status: | CLOSED COMPLETED | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 36 | CC: | acaringi, adscvr, airlied, alciregi, bskeggs, hdegoede, hpa, jarodwilson, javierm, jglisse, jonathan, josef, kernel-maint, lgoncalv, linville, masami256, mchehab, ptalbert, steved |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-05-25 17:01:45 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
David Santamaría Rogado
2022-04-01 23:17:55 UTC
David, thank you your bug report. I did already notice and fix this issue and the fix did land upstream recently: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=94fa115f7b28a3f02611499175e134f0a823b686 I've just also submitted the fix to get backported to the 5.17 series: https://lore.kernel.org/stable/20220402093029.5334-1-hdegoede@redhat.com/T/#t So it should show up in 5.17.2 (with some luck) or otherwise 5.17.3 . p.s. Does your d330 have a touchscreen? And does the touchscreen work properly under Fedora 36 ? I'm asking this because there is a bug report that the goodix touchscreen driver is broken on the d330: https://bugzilla.kernel.org/show_bug.cgi?id=209061 The fix for this has been queued up upstream for inclusion into 5.17.2, so once the Fedora update to 5.17.2 becomes available this should be resolved. Yes, the touchscreen it's a goodix one. With 36 beta it's working. Thanks for the fix and sorry for not checking it existed before. (In reply to David Santamaría Rogado from comment #4) > Yes, the touchscreen it's a goodix one. With 36 beta it's working. That is good to know, thanks. > Thanks for the fix and sorry for not checking it existed before. You're welcome and no need to apologize, your bugreport was actually useful, because it made me submit the patch for inclusion into the 5.17.y series, so that the fix will actually become available in Fedora 36 soon. Otherwise things would have been been broken until Fedora jumped to the 5.18 kernels, so thank you for your bug report. I have to reopen the bug. I have not tested live this time but upgraded the installed system. The output when simpledrm compatibility fb is active is still portrait oriented and with wrong pitch. What I have seen different now is that plymouth doesn't scale up the logo and spinner so the are 1:1 scale pixel. 5.17.7-300.fc36.x86_64 in use. (In reply to David Santamaría Rogado from comment #6) > I have to reopen the bug. > > I have not tested live this time but upgraded the installed system. The > output when simpledrm compatibility fb is active is still portrait oriented > and with wrong pitch. > > What I have seen different now is that plymouth doesn't scale up the logo > and spinner so the are 1:1 scale pixel. > > 5.17.7-300.fc36.x86_64 in use. Ok, so 5.17.7 does have this commit: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=94fa115f7b28a3f02611499175e134f0a823b686 So the orientation of the fbcon on top of simlpedrm should be correct. But you also mention a pitch issue. I guess the pitch issue (that is width and height being swapped) is the real problem here and because of that the orientation quirk does not apply because the resolution does not match. This is supposed to be fixed by the code at: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/firmware/efi/sysfb_efi.c#n344 But it seems this is not. I guess that for some reason that code is not running when using simpledrm. I'm adding Javier who has been the main driving force behing the move to simpledrm to the Cc. Javier, is it possible that the code at sysfb_efi.c line 344 is not running / not having the desired effect when using simpledrm ? Yes, the code at sysfb_efi.c#n334 solved it when using fbdev. Sorry for double posting, the orientation actually is also portrait, don't know if when the pitch is corrected will also affect it, but now the interleaved effect of the wrong pitch grows like the first 5.17 kernels from left to right, so the lines are write from down to top. This message is a reminder that Fedora Linux 36 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora Linux 36 on 2023-05-16. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a 'version' of '36'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, change the 'version' to a later Fedora Linux version. Note that the version field may be hidden. Click the "Show advanced fields" button if you do not see it. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora Linux 36 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora Linux, you are encouraged to change the 'version' to a later version prior to this bug being closed. Fedora Linux 36 entered end-of-life (EOL) status on 2023-05-16. Fedora Linux 36 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora Linux please feel free to reopen this bug against that version. Note that the version field may be hidden. Click the "Show advanced fields" button if you do not see the version field. If you are unable to reopen this bug, please file a new report against an active release. Thank you for reporting this bug and we are sorry it could not be fixed. It work right nowadays, even out of the box with Fedora 38. The needinfo request[s] on this closed bug have been removed as they have been unresolved for 120 days |