Bug 2071691

Summary: OCP Console global PatternFly overrides adds padding to breadcrumbs
Product: OpenShift Container Platform Reporter: James Talton <jtalton>
Component: Management ConsoleAssignee: Steve Goodwin <sgoodwin>
Status: CLOSED ERRATA QA Contact: Yanping Zhang <yanpzhan>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.10CC: aos-bugs, cjerolim, jhadvig, nmukherj, sgoodwin, yanpzhan, yapei
Target Milestone: ---   
Target Release: 4.11.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of:
: 2076275 (view as bug list) Environment:
Last Closed: 2022-08-10 11:03:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 2076275    

Description James Talton 2022-04-04 14:39:38 UTC
Description of problem:
  OCP Console global PatternFly overrides adds padding to breadcrumbs
  This affects the breadcrumbs of dynamic plugins.
  _overrides.scss
    .pf-c-breadcrumb {
      padding-bottom: 12px;
      padding-top: 25px;
      &--no-padding-top {
        padding-top: 0;
      }
    }

  The 'all clusters' view for OCP 4.10 using the MCE/ACM dynamic plugins and breadcrumbs show the extra padding.

Version-Release number of selected component (if applicable): 4.10

How reproducible: Always

Steps to Reproduce:
1. OCP 4.10 with MCE installed
2. Select "All clusters" from the cluster switcher
3. Click on a cluster name
4. Cluster details page will has a breadcrumb with extra padding

Actual results:


Expected results:


Additional info:

Comment 1 Christoph Jerolimov 2022-04-05 14:10:32 UTC
Let us try to remove any custom CSS and use pure PF styles for this.

Comment 4 Steve Goodwin 2022-04-20 18:51:03 UTC
Hi Yanping, Please confirm that this bug can now be manually moved to VERIFIED. Thanks

Comment 5 Yanping Zhang 2022-04-21 04:18:10 UTC
On ocp 4.11 cluster with payload 4.11.0-0.nightly-2022-04-16-163450, install ACM 2.5 with Snapshot: 2.5.0-SNAPSHOT-2022-04-20-06-50-05.
Visit All Clusters from cluster switcher. Access menus will meet 404 page, the test is blocked by https://bugzilla.redhat.com/show_bug.cgi?id=2071690

Comment 6 Yanping Zhang 2022-04-29 12:58:49 UTC
Checked on ocp 4.11 cluster with payload 4.11.0-0.nightly-2022-04-26-181148, install ACM 2.5 with Snapshot 2.5.0-SNAPSHOT-2022-04-29-10-02-38.
Use a new browser which didn't access previous versions of the ACM plugin.
1. Login console.
2. Select "All clusters" from the cluster switcher
3. Click on a cluster name
4. Cluster details page, check breadcrumb, it looks normal. But check in dev console, the nav element has not class "co-breadcrumb"; if check on deployment details page, the nav element has class "co-breadcrumb".  @S

Comment 7 Yanping Zhang 2022-04-29 13:00:26 UTC
@steve If the result in step 4 in Comment 6 is expected? pls refer to screenshot.

Comment 10 Steve Goodwin 2022-04-29 20:19:35 UTC
Yanping these changes wouldn't effect the ACM plugin pages, since they don't use our css styles. 

This bug is only for the standard Admin/Dev console pages.

Comment 11 Steve Goodwin 2022-05-03 17:51:31 UTC
This bug verification is required for https://bugzilla.redhat.com/show_bug.cgi?id=2076275 to be back ported to version 4.10

Comment 12 Yanping Zhang 2022-05-05 01:51:53 UTC
According to Comment 6 and Comment 10, the fix in pr works in Admin/Dev console. So move the bug to Verified.

Comment 14 errata-xmlrpc 2022-08-10 11:03:18 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Container Platform 4.11.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5069