Bug 207173

Summary:	Review Request: pymsn - Python libraries for MSN Messenger network
Product:	[Fedora] Fedora	Reporter:	Brian Pepple <bdpepple>
Component:	Package Review	Assignee:	Sander Hoentjen <sander>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-09-29 18:05:24 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779, 207607

Description Brian Pepple 2006-09-19 20:05:23 UTC

Spec URL: http://piedmont.homelinux.org/fedora/telepathy/pymsn.spec
SRPM URL: http://piedmont.homelinux.org/fedora/telepathy/pymsn-0.2-1.src.rpm
Description: pymsn is the library behind the msn connection manager for telepathy. It is a rewrite of the libivy msn library used in the Ivy msn client. pymsn uses the glib mainloop to process the network events in an asynchronous manner

Comment 1 Sander Hoentjen 2006-09-29 08:35:22 UTC

Good:

- rpmlint checks return nothing
- package meets naming guidelines
- package meets packaging guidelines
- license (LGPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

APPROVED