Bug 2072661

Summary: Workaround overlapping labels caused by gtk4 bug
Product: [Fedora] Fedora Reporter: Daniel Rusek <drusek>
Component: gnome-softwareAssignee: Milan Crha <mcrha>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 36CC: fzatlouk, gnome-sig, kparal, mail, mcrha, rhughes
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: AcceptedFreezeException
Fixed In Version: gnome-software-42.0-2.fc36 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-04-11 22:52:24 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1953786    
Attachments:
Description Flags
Overlapping label of "System Updates"
none
Overlapping label of software summary none

Description Daniel Rusek 2022-04-06 17:58:09 UTC
Description of problem:
Due to gtk#4714, multi-line labels result in app-row displaying overlapping text. There is a very simple workaround already available and merged in gnome-software Git (will be part of 42.1). Please, consider backporting this workaround as a patch before Fedora 36 Final.

Version-Release number of selected component (if applicable):
gnome-software-42.0-1.fc36.x86_64
gtk4-4.6.2-2.fc36.x86_64

How reproducible:
Every time.

Steps to Reproduce:
Reproducer 1:
1. Install Fedora 36 Beta.
2. Open Software and switch to the Updates tab.
3. See the System Updates label.

Reproducer 2:
1. Install Fedora 36 Beta.
2. Open Software and search for "libreoffice" (or another software that has longer summary text).
3. See the software summary label.

Actual results:
See the attached screenshots.

Expected results:
Labels don't overlap.

Additional info:
https://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/1313
https://gitlab.gnome.org/GNOME/gtk/-/issues/4714

Comment 1 Daniel Rusek 2022-04-06 18:00:07 UTC
Created attachment 1871127 [details]
Overlapping label of "System Updates"

Comment 2 Daniel Rusek 2022-04-06 18:01:04 UTC
Created attachment 1871128 [details]
Overlapping label of software summary

Comment 3 Fedora Blocker Bugs Application 2022-04-06 18:12:22 UTC
Proposed as a Freeze Exception for 36-final by Fedora user asciiwolf using the blocker tracking app because:

 Due to a gtk4 bug, multi-line labels result in app-row displaying overlapping text in Software. This looks bad and makes the out-of-box user experience worse. There is a simple workaround available and already merged in Git (will be part of 42.1). Please, consider backporting this workaround into Fedora 36 before Final.

Comment 4 Milan Crha 2022-04-07 07:25:54 UTC
Thanks for a bug report. Even it's just a visual glitch, I can backport it, it's a trivial fix. I'll do it, if the exception is granted.

Comment 5 František Zatloukal 2022-04-09 11:23:36 UTC
Discussed in ticket: https://pagure.io/fedora-qa/blocker-review/issue/725

The decision to classify this bug as an AcceptedFreezeException was made:

"It's annoying visual glitch which has a high probability of visibility before updating the GA installed system. As per developer, the fix is low risk."

Comment 6 Fedora Update System 2022-04-11 10:50:27 UTC
FEDORA-2022-e5ddaf87b7 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-e5ddaf87b7

Comment 7 Kamil Páral 2022-04-11 11:49:51 UTC
The labels are no longer overlapping, instead they are ellipsized as "text...". I assume that's the intention.

Comment 8 Milan Crha 2022-04-11 12:32:25 UTC
(In reply to Kamil Páral from comment #7)
> I assume that's the intention.

Correct.

Comment 9 Fedora Update System 2022-04-11 14:57:40 UTC
FEDORA-2022-e5ddaf87b7 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-e5ddaf87b7`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-e5ddaf87b7

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2022-04-11 22:52:24 UTC
FEDORA-2022-e5ddaf87b7 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.