Bug 2072742

Summary: storage - support for adding/removing disks to/from storage pools
Product: Red Hat Enterprise Linux 9 Reporter: David Lehman <dlehman>
Component: rhel-system-rolesAssignee: Rich Megginson <rmeggins>
Status: CLOSED ERRATA QA Contact: Lin Li <lilin>
Severity: medium Docs Contact: Michal Stubna <mstubna>
Priority: unspecified    
Version: 9.0CC: gfialova, jharuda, lilin, nhosoi, rhel-cs-system-management-subsystem-qe, rmeggins, spetrosi, vtrefny
Target Milestone: rcKeywords: Triaged
Target Release: 9.1   
Hardware: All   
OS: Linux   
Whiteboard: role:storage
Fixed In Version: rhel-system-roles-1.19.3-1.el9 Doc Type: Enhancement
Doc Text:
.The `storage` RHEL System Role now supports managing the pool members The `storage` RHEL System Role can now add or remove disks from existing LVM pools without removing the pool first. To increase the pool capacity, the `storage` RHEL system role can add new disks to the pool and free currently allocated disks in the pool for another use.
Story Points: ---
Clone Of: 2066880 Environment:
Last Closed: 2022-11-15 10:23:26 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2066880, 2078803, 2079221, 2081278    
Bug Blocks:    

Description David Lehman 2022-04-06 21:45:58 UTC
+++ This bug was initially created as a clone of Bug #2066880 +++

Description of problem:
The storage role should be able to add and remove disks to/from storage pools

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Lin Li 2022-04-21 03:11:16 UTC
Hi Vojtech,
Could you kindly tell me how to verify the bug?
Thanks in advance!

Comment 2 Rich Megginson 2022-04-27 21:43:12 UTC
(In reply to Lin Li from comment #1)
> Hi Vojtech,
> Could you kindly tell me how to verify the bug?
> Thanks in advance!

See https://github.com/linux-system-roles/storage/pull/264 - there is a test for this

Comment 4 Lin Li 2022-06-28 03:23:55 UTC
The below error happened. 
# ansible-playbook tests_lvm_pool_members.yml
fatal: [127.0.0.1]: FAILED! => {"msg": "Invalid data passed to 'loop', it requires a list, got this instead: [] + [ '/dev/sdr1' ] + [ '/dev/sds1' ] + [ '/dev/sdt1' ] + [ '/dev/sdu1' ] + [ '/dev/sdv1' ] + [ '/dev/sdw1' ] + [ '/dev/sdx1' ] + [ '/dev/sdy1' ] + [ '/dev/sdz1' ]. Hint: If you passed a list/dict of just one element, try adding wantlist=True to your lookup invocation or use q/query instead of lookup."}

PLAY RECAP *********************************************************************
127.0.0.1                  : ok=54   changed=1    unreachable=0    failed=1    skipped=35   rescued=0    ignored=0

Comment 8 Lin Li 2022-07-08 05:32:16 UTC
Verified on rhel-system-roles-1.19.3-1.el9
[root@storageqe-25 tests]# rpm -qa | grep  rhel-system-roles
rhel-system-roles-1.19.3-1.el9.noarch

[root@storageqe-25 tests]# ansible-playbook tests_lvm_pool_members.yml
PLAY RECAP *********************************************************************
127.0.0.1                  : ok=693  changed=37   unreachable=0    failed=0    skipped=500  rescued=0    ignored=0

Comment 12 errata-xmlrpc 2022-11-15 10:23:26 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (rhel-system-roles bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2022:8117