Bug 2073629
| Summary: | Review Request: golang-entgo-ent - An entity framework for Go | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michel Lind <michel> |
| Component: | Package Review | Assignee: | Davide Cavalca <davide> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | davide, package-review |
| Target Milestone: | --- | Flags: | davide:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-05-21 01:30:32 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2045503 | ||
|
Description
Michel Lind
2022-04-09 01:51:43 UTC
Taking this review This is missing the src.rpm Spec URL: https://download.copr.fedorainfracloud.org/results/salimma/misc-wip/fedora-rawhide-x86_64/04395233-golang-entgo-ent/golang-entgo-ent.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/salimma/misc-wip/fedora-rawhide-x86_64/04395233-golang-entgo-ent/golang-entgo-ent-0.10.0-1.fc37.src.rpm COPR builds and review templates: https://copr.fedorainfracloud.org/coprs/salimma/misc-wip/build/4395233/ %if %{with check}
# Tests
BuildRequires: golang(github.com/DATA-DOG/go-sqlmock)
# BuildRequires: golang(github.com/google/uuid)
# BuildRequires: golang(github.com/gorilla/websocket)
BuildRequires: golang(github.com/jessevdk/go-flags)
BuildRequires: golang(github.com/json-iterator/go)
# BuildRequires: golang(github.com/modern-go/reflect2)
BuildRequires: golang(github.com/stretchr/testify/assert)
BuildRequires: golang(github.com/stretchr/testify/mock)
BuildRequires: golang(github.com/stretchr/testify/require)
BuildRequires: golang(golang.org/x/tools/go/packages/packagestest)
# BuildRequires: golang(go.opencensus.io/stats/view)
# BuildRequires: golang(go.opencensus.io/trace)
%endif
Why the commented BRs?
# goimport fails to pick up these
Should we file a bug on the golang macros for this?
%generate_buildrequires
# %%go_generate_buildrequires
I think you have some debugging leftover here
%doc doc examples README.md README_jp.md CODE_OF_CONDUCT.md CONTRIBUTING.md
%doc README_zh.md entc/integration/README.md doc
entc/integration/README.md will overwrite the top-level readme; either drop it from %doc (and from godocs), or rename it to something else first
the go_generate_buildrequires didn't work - so yeah, I'll just remove them, seems like most golang packages don't use it yet, it's not in as good a shape as the Python and Rust generators. as for the other comments - I can't quite remember, it's been too long. I'll just remove them for now. Will also rename the integration doc. Thanks! Updated builds: https://copr.fedorainfracloud.org/coprs/salimma/misc-wip/build/4398994/ (ignore the build failure, I forgot to manually deselect i386 again) Spec URL: https://download.copr.fedorainfracloud.org/results/salimma/misc-wip/fedora-rawhide-x86_64/04398994-golang-entgo-ent/golang-entgo-ent.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/salimma/misc-wip/fedora-rawhide-x86_64/04398994-golang-entgo-ent/golang-entgo-ent-0.10.0-1.fc37.src.rpm # remove failing tests rm entc/internal/snapshot_test.go rm entc/load/load_test.go These are probably worth adding a comment and/or filing an upstream issue for. Besides that, package was generated with go2rpm simplifying the review. - Conforms to packaging guidelines - license correct and valid - builds and installs PACKAGE APPROVED. ah yes, agreed. Will do before importing the package, thanks. ❯ fedpkg request-repo golang-entgo-ent 2073629 https://pagure.io/releng/fedora-scm-requests/issue/44391 ❯ fedpkg request-branch --repo golang-entgo-ent --all-releases https://pagure.io/releng/fedora-scm-requests/issue/44392 https://pagure.io/releng/fedora-scm-requests/issue/44393 https://pagure.io/releng/fedora-scm-requests/issue/44394 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-entgo-ent FEDORA-2022-0bf1adbda6 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-0bf1adbda6 FEDORA-2022-0bf1adbda6 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-0bf1adbda6 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-0bf1adbda6 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-f2936c69e9 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-f2936c69e9 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-f2936c69e9 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-0bf1adbda6 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-f2936c69e9 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. |