Bug 2073841

Summary:	Review Request: rust-imbl - Immutable collection datatypes
Product:	[Fedora] Fedora	Reporter:	Michel Lind <michel>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-11-13 00:45:35 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	201449

Description Michel Lind 2022-04-10 19:36:36 UTC

Spec URL: https://download.copr.fedorainfracloud.org/results/salimma/nu-wip/fedora-rawhide-x86_64/04164911-rust-im/rust-im.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/salimma/nu-wip/fedora-rawhide-x86_64/04164911-rust-im/rust-im-15.0.0-1.fc37.src.rpm
Description: Immutable collection datatypes.
Fedora Account System Username: salimma

COPR build: https://copr.fedorainfracloud.org/coprs/salimma/nu-wip/build/4164911/

(note: had to disable fedora-review since it seemed to crash: https://copr.fedorainfracloud.org/coprs/salimma/nu-wip/build/4164488/ - logs not kept so it's hard to know what went wrong, but the packages are installable in mock)

Comment 1 Fabio Valentini 2022-04-10 19:54:53 UTC

Do you really really really need this crate? It's been abandoned by upstream for almost two years, and has critical bugs:

https://github.com/RustSec/advisory-db/pull/891

It wasn't marked as UNMAINTAINED by RUSTSEC on the base of a technicality, but in reality, the project has been dead since mid-2020, with the maintainer being unresponsive.

Comment 2 Michel Lind 2022-04-11 17:39:21 UTC

hmm. it's needed by nu-protocol: https://crates.io/crates/nu-protocol/0.60.0/dependencies -- but let me file a bug there with the RustSec advisory and see what they think. Thanks!

Comment 3 Michel Lind 2022-04-11 17:47:35 UTC

Filed https://github.com/nushell/nushell/issues/5160 -- given the discussion in the thread, I'm going to try packaging `imbl` which is API compatible and seems maintained

Comment 4 Michel Lind 2022-04-11 20:18:52 UTC

Switch to the maintained imbl fork

Spec URL: https://download.copr.fedorainfracloud.org/results/salimma/nu-wip/fedora-rawhide-i386/04179419-rust-imbl/rust-imbl.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/salimma/nu-wip/fedora-rawhide-i386/04179419-rust-imbl/rust-imbl-1.0.1-1.fc37.src.rpm

COPR build: https://copr.fedorainfracloud.org/coprs/salimma/nu-wip/build/4179419/

Comment 5 Michel Lind 2022-04-11 20:19:35 UTC

note: the COPR x86_64 directory is missing some files, looks like it happened if I open the result directory mid-build

Comment 6 Fabio Valentini 2022-04-13 10:07:53 UTC

There was a 2.0.0 release of imbl a few hours ago - it looks like it doesn't contain any big breaking changes.
If you can use 2.0.0 instead of 1.0.1, please update.

Comment 7 Package Review 2022-11-13 00:45:35 UTC

This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.