Bug 207409

Summary: Back button on Installation Media screen always goes to Para/Full selection, regardless of is_hvm_capable
Product: [Fedora] Fedora Reporter: William Sheehan <william.sheehan>
Component: virt-managerAssignee: Daniel Berrangé <berrange>
Status: CLOSED RAWHIDE QA Contact: Brian Brock <bbrock>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhide   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-09-27 15:49:50 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch to create.py that examines xeninst.util.is_hvm_capable() when clicking Back on Installation Media none

Description William Sheehan 2006-09-20 22:47:00 UTC 
Description of problem:

In the wizard for creating a new virtual machine, there is a check in create.py
that determines whether or not to show the Paravirtualization/Full
Virtualization screen based on the value of xeninst.util.is_hvm_capable(). 
However, this logic is only implemented for the Forward button, not for Back. 
The end result is that on machines that are not HVM capable, hitting Back on the
Installation Media screen always shows the virtualization selection.


Version-Release number of selected component (if applicable):

virt-manager-0.2.2-1.fc6


Steps to Reproduce:
1. Start the new VM wizard on a machine that does not support HVM
2. On the Installation Media screen, click Back.

  
Actual results:

The Paravirtualization/Full Virtualization selection screen is shown.


Expected results:

The logical previous screen (machine name in the current codebase) should be
shown.  The virtualization type was skipped going forward, it should be skipped
going backwards as well.


Additional info:

I have attached a patch that does a simple check of
xeninst.util.is_hvm_capable() in the back code for screen 4 (Installation
Media).  If true, show the selection, else show the machine name screen.
Comment 1 William Sheehan 2006-09-20 22:47:00 UTC 
Created attachment 136795 [details]
Patch to create.py that examines xeninst.util.is_hvm_capable() when clicking Back on Installation Media
Comment 2 Daniel Berrangé 2006-09-22 16:37:10 UTC 
Applied patch to upstream sources for virt-manager. Will be included in next RPM
built for rawhide.
Comment 3 Daniel Berrangé 2006-09-27 15:49:50 UTC 
This issue is fixed in virt-manager-0.2.3-1.fc6 which will appear in rawhide
within the next day.