Bug 2074237

Description of problem:
oc new-app https://github.com/sclorg/nodejs-ex --image-stream=cli:latest

does not do the right thing.

If you look at the resources produced from this invocation, the "cli:latest" imagestream is only used as a trigger for the app deployment.

cli:latest should be used as the builder image for the github repo.

Instead, new-app still inspects the repo, detects it as a nodejs app, and attempts to use the nodejs builder imagestream.  Meaning you can't force new-app to use "cli:latest" as the builder image instead.

so it's not clear what --image-stream is actually doing in this invocation.

passing --image has similarly strange behavior, all it does is add an imagestream pointing to the image in question, but it doesn't consume the image/imagestream for building the app.

The only way to actually specify the builder image to use, is to use this syntax:

oc new-app someimage~https://github.com/sclorg/nodejs-ex

where someimage can be either an imagestream or an image.


If the intent isn't that the value passed to --image-stream be used as the builder image for the repo being provided, then at least we need to clarify in the help just what the argument is used for.  It doesn't seem to do much, at least when you're using new-app to construct buildconfigs.  Perhaps when using it to just deploy an app based on an existing imagestream it makes more sense.



Version-Release number of selected component (if applicable):
v4.11 but probably older too

How reproducible:
always

Actual results:
--image-stream argument isn't really used by the resulting artifacts

Expected results:
either it's used, or the help text makes it clearer what the behavior is intended to be.  Same for --image.