Bug 2074833

Summary: Oddly packaged systemd cryptsetup plugins
Product: Red Hat Enterprise Linux 9 Reporter: Ondrej Kozina <okozina>
Component: systemdAssignee: systemd-maint
Status: CLOSED ERRATA QA Contact: Frantisek Sumsal <fsumsal>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 9.0CC: dtardon, evan, extras-qa, fedoraproject, filbranden, flepied, gmazyland, jamacku, lnykryn, msekleta, ryncsn, ssahani, s, systemd-maint-list, systemd-maint, vkuznets, yuwatana, zbyszek
Target Milestone: rcKeywords: Improvement, TestOnly, Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: systemd-252-3.el9 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 2031873 Environment:
Last Closed: 2023-05-09 08:21:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2031873, 2138081    
Bug Blocks: 2064804    

Description Ondrej Kozina 2022-04-13 08:30:31 UTC
+++ This bug was initially created as a clone of Bug #2031873 +++

Description of problem:

Seems that systemd cryptsetup plugins are oddly packaged in systemd-devel sub-package (therefore not installed usually). Not sure what final destination should be, but I have used attached patch to create systemd-cryptsetup-plugins subpackage when I was devel/testing it.

There should probably be some dependencies so that systemd-cryptsetup and systemd-cryptenroll pull the plugins in.

Version-Release number of selected component (if applicable):
systemd-250~rc1-2.fc36

--- Additional comment from Zbigniew Jędrzejewski-Szmek on 2021-12-13 20:26:17 UTC ---

Hmm, why create a separate subpackage? I'd just put those files in systemd-udev.
Or in other words, when would you install systemd-cryptsetup-plugins but not system-udev?

--- Additional comment from Zbigniew Jędrzejewski-Szmek on 2021-12-14 18:09:25 UTC ---

I moved those plugins to -udev for now.

--- Additional comment from Ondrej Kozina on 2021-12-14 19:15:31 UTC ---

Ok, thanks! It seems to work just fine.

--- Additional comment from Evan Anderson on 2022-03-13 19:26:17 UTC ---

This appears to be broken again on F36. The systemd-devel package is back to providing libcryptsetup-token-system-* libraries. https://koji.fedoraproject.org/koji/rpminfo?rpmID=29600259

--- Additional comment from Evan Anderson on 2022-03-13 23:18:50 UTC ---

The issue stems from how the devel regex in split-files.py treats .so files. It assumes that any .so file in a lib directory, with the exception of libsystemd-shared-*.so, are development libraries. The newly added libcryptsetup-token* shared libraries break this assumption. The regex needs to be updated to ignore the cryptsetup libs since those will be picked up later by the matching rule for -udev. I've attached a patch that makes this correction.

--- Additional comment from Milan Broz on 2022-03-14 07:10:06 UTC ---

(In reply to Evan Anderson from comment #5)
> Created attachment 1865807 [details]
> Fix regex for -devel

Can you please reopen the bug then or create a new one? That patch is not in systemd build yet.

--- Additional comment from Ondrej Kozina on 2022-03-16 15:26:09 UTC ---

I can confirm it reappears in systemd-devel package.

--- Additional comment from Evan Anderson on 2022-03-18 02:17:21 UTC ---

Looks like the change messed up the packaging even more. systemd no longer provides libsystemd-shared-250.so, which results in broken dependencies. Culprit looks to be the use of re.match instead of re.search in the change [1], combined with the use of the * instead of .* for the libsystemd-shared matching. re.match only matches from the beginning of the line, and * in regex matches 0 or more of the preceding character (in this case, -).

[1] https://src.fedoraproject.org/rpms/systemd/c/0078f9a1029bbfd9dc12e79032072a7ff46182a6?branch=rawhide)

--- Additional comment from Zbigniew Jędrzejewski-Szmek on 2022-03-18 12:41:18 UTC ---

Arrgh. It was late, and I was tired and didn't want to wait for the full build and I thought the change is simple enough to "just work".
Should be fixed with the version that is building now.

--- Additional comment from Zbigniew Jędrzejewski-Szmek on 2022-03-29 20:12:47 UTC ---

This was fixed in F36 and rawhide in the last build.

Comment 1 Ondrej Kozina 2022-04-13 08:32:09 UTC
I've noticed same issue also in RHEL9 builds recently

Version: systemd-250-6.el9_0

Comment 3 David Tardon 2022-12-07 14:13:42 UTC
*** Bug 2141380 has been marked as a duplicate of this bug. ***

Comment 4 Jan Macku 2023-01-24 13:00:34 UTC
This issue should be fixed via rebase to systemd v252.

Comment 7 errata-xmlrpc 2023-05-09 08:21:58 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (systemd bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:2531