Bug 2075108

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

https://hackage.haskell.org/package/linear

Hackage Reverse Dependencies: 145 direct, 155 indirect

This no longer builds.
Please try updating to 
Version:        1.22

Be more specific
License: BSD-3-Clause

rpmlint on the output shows a number of problems to resolve.
This will likely change the specfile so reserving comment for the update.

Thanks, Tom, for taking a look

Spec URL: https://petersen.fedorapeople.org/reviews/ghc-linear/ghc-linear.spec
SRPM URL: https://petersen.fedorapeople.org/reviews/ghc-linear/ghc-linear-1.22-1.fc40.src.rpm

update to 1.22

Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=111281980

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6861659
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2075108-ghc-linear/fedora-rawhide-x86_64/06861659-ghc-linear/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Could a %check be added ?

Some rpmlint issues
ghc-linear-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ghc-9.4.5/lib/linear-1.22/libHSlinear-1.22-2INZOSVkR06IDmMKWeXTee.a 

ghc-linear.x86_64: E: unused-direct-shlib-dependency /usr/lib64/ghc-9.4.5/lib/libHSlinear-1.22-2INZOSVkR06IDmMKWeXTee-ghc9.4.5.so /usr/lib64/ghc-9.4.5/lib/libH\
Ssplitmix-0.1.0.4-7e8CibdlMRLAGh7KO5VlFe-ghc9.4.5.so   

many similar.

(In reply to Jens Petersen from comment #4)
> Thanks, Tom, for taking a look

I picked this review because it is similar to ones I am doing for AMD GPU's.
If you have time and interest could you look at 
https://bugzilla.redhat.com/show_bug.cgi?id=2249410

(My motivation for this package is to get https://hackage.haskell.org/package/sdl2 into Fedora and then possibly later monomer for example)

(In reply to Tom Rix from comment #7)
> Could a %check be added ?

# testsuite missing deps: simple-reflect test-framework test-framework-hunit

Not really, due to these missing deps.

> Some rpmlint issues
> ghc-linear-devel.x86_64: E: static-library-without-debuginfo
> /usr/lib64/ghc-9.4.5/lib/linear-1.22/libHSlinear-1.22-2INZOSVkR06IDmMKWeXTee.a 

I think this is expected: we have Packaging exception in the Haskell Policy I think.

> ghc-linear.x86_64: E: unused-direct-shlib-dependency
> /usr/lib64/ghc-9.4.5/lib/libHSlinear-1.22-2INZOSVkR06IDmMKWeXTee-ghc9.4.5.so
> /usr/lib64/ghc-9.4.5/lib/libHSsplitmix-0.1.0.4-7e8CibdlMRLAGh7KO5VlFe-ghc9.4.5.so   
>
> many similar.

I will try to have a look but not sure I can do anything about this/these.
(More raw output would be helpful though.)


[Puzzled by @fedora-review's output, or rather why not:

(none): E: there is no installed rpm "ghc-linear-prof".
(none): E: there is no installed rpm "ghc-linear-devel".
(none): E: there is no installed rpm "ghc-linear".
]

I reported unused-direct-shlib-dependency to ghc upstream some time back
in https://gitlab.haskell.org/ghc/ghc/-/issues/23216
- nothing really I can easily do about it.

The same is true for many other Haskell libraries ("ldd -u" output) - I don't think it is very serious though.

Just wanted to add that Haskell library packaging is fairly standardized.
It is all based on cabal-rpm and ghc-rpm-macros.
So the most important things to check are the license
and any packaging deviations. (Of course it would be better/easier
if ghc moved more closely in line with standard toolchains
to avoid these kinds of rpmlint errors/warnings.)

I am not sure about the 'no installed rpm' , works for me.
I looked at the unused-direct-shlib-dependency you raised, you tried.. i wish upstream would be more responsive but sometimes like pushing a rope.
Thanks for taking care of the issues you could.
Approved.

Thank you for the review, Tom!

The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-linear

FEDORA-2024-70ae4692fd has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-70ae4692fd

FEDORA-2024-70ae4692fd has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-70ae4692fd \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-70ae4692fd

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2024-70ae4692fd has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.