Bug 2075263

Summary: CVE-2022-24785 python-notebook: Moment.js: Path traversal in moment.locale [fedora-all]
Product: [Fedora] Fedora Reporter: Anten Skrabec <askrabec>
Component: python-notebookAssignee: Miro Hrončok <mhroncok>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: 35CC: ksurma, mhroncok, python-sig
Target Milestone: ---Keywords: Reopened, Security, SecurityTracking
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-notebook-6.4.11-3.fc37 python-notebook-6.4.11-3.fc36 python-notebook-6.4.0-4.fc35 python-notebook-7.0.0-1.fc39 Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-07-23 01:59:49 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2072009    
Attachments:
Description Flags
Basic patch for bundled moment none

Description Anten Skrabec 2022-04-13 21:56:36 UTC
This is an automatically created tracking bug!  It was created to ensure
that one or more security vulnerabilities are fixed in affected versions
of fedora-all.

For comments that are specific to the vulnerability please use bugs filed
against the "Security Response" product referenced in the "Blocks" field.

For more information see:
http://fedoraproject.org/wiki/Security/TrackingBugs

When submitting as an update, use the fedpkg template provided in the next
comment(s).  This will include the bug IDs of this tracking bug as well as
the relevant top-level CVE bugs.

Please also mention the CVE IDs being fixed in the RPM changelog and the
fedpkg commit message.

NOTE: this issue affects multiple supported versions of Fedora. While only
one tracking bug has been filed, please correct all affected versions at
the same time.  If you need to fix the versions independent of each other,
you may clone this bug as appropriate.

Comment 1 Anten Skrabec 2022-04-13 21:56:38 UTC
Use the following template to for the 'fedpkg update' request to submit an
update for this issue as it contains the top-level parent bug(s) as well as
this tracking bug.  This will ensure that all associated bugs get updated
when new packages are pushed to stable.

=====

# bugfix, security, enhancement, newpackage (required)
type=security

# low, medium, high, urgent (required)
severity=medium

# testing, stable
request=testing

# Bug numbers: 1234,9876
bugs=2072009,2075263

# Description of your update
notes=Security fix for [PUT CVEs HERE]

# Enable request automation based on the stable/unstable karma thresholds
autokarma=True
stable_karma=3
unstable_karma=-3

# Automatically close bugs when this marked as stable
close_bugs=True

# Suggest that users restart after update
suggest_reboot=False

======

Additionally, you may opt to use the bodhi web interface to submit updates:

https://bodhi.fedoraproject.org/updates/new

Comment 2 Miro Hrončok 2022-04-13 22:16:47 UTC
*** Bug 2075300 has been marked as a duplicate of this bug. ***

Comment 3 Miro Hrončok 2022-07-13 09:05:41 UTC
Created attachment 1896641 [details]
Basic patch for bundled moment

I have attached a basic patch for moment that should fix CVE-2022-24785 and CVE-2022-31129.


By running the following from prepped sources:


  $ npm install
  $ python3 setup.py js

I was able to propagate the changes to other files:

	modified:   notebook/static/edit/js/main.min.js
	modified:   notebook/static/edit/js/main.min.js.map
	modified:   notebook/static/notebook/js/main.min.js
	modified:   notebook/static/notebook/js/main.min.js.map
	modified:   notebook/static/terminal/js/main.min.js
	modified:   notebook/static/terminal/js/main.min.js.map
	modified:   notebook/static/tree/js/main.min.js
	modified:   notebook/static/tree/js/main.min.js.map


But I still have no ide how to force recreation of notebook/static/components/moment/min/moment-with-locales.min.js and notebook/static/components/moment/min/moment.min.js.

Comment 4 Miro Hrončok 2022-07-13 09:49:51 UTC
OK, I've modified the min.js files manually :/

https://src.fedoraproject.org/rpms/python-notebook/pull-request/35

Comment 5 Fedora Update System 2022-07-14 11:30:18 UTC
FEDORA-2022-f9e459c893 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-f9e459c893

Comment 6 Fedora Update System 2022-07-14 11:33:13 UTC
FEDORA-2022-f9e459c893 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fedora Update System 2022-07-14 22:09:39 UTC
FEDORA-2022-85aa8e5706 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-85aa8e5706

Comment 8 Fedora Update System 2022-07-14 22:09:43 UTC
FEDORA-2022-35b698150c has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-35b698150c

Comment 9 Fedora Update System 2022-07-15 01:20:53 UTC
FEDORA-2022-35b698150c has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-35b698150c`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-35b698150c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2022-07-15 02:09:26 UTC
FEDORA-2022-85aa8e5706 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-85aa8e5706`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-85aa8e5706

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2022-07-23 01:59:49 UTC
FEDORA-2022-35b698150c has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2022-07-23 02:27:18 UTC
FEDORA-2022-85aa8e5706 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2023-07-20 11:56:02 UTC
FEDORA-2023-3256575fc8 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-3256575fc8

Comment 14 Fedora Update System 2023-07-20 11:58:11 UTC
FEDORA-2023-3256575fc8 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.