Bug 2075594

Summary:	Deprovisioned clusters not filtered out by discovery controller
Product:	Red Hat Advanced Cluster Management for Kubernetes	Reporter:	Thuy Nguyen <thnguyen>
Component:	Installer	Assignee:	Jakob <jagray>
Status:	CLOSED ERRATA	QA Contact:	txue
Severity:	high	Docs Contact:	Christopher Dawson <cdawson>
Priority:	unspecified
Version:	rhacm-2.4.z	CC:	ecai
Target Milestone:	---	Flags:	bot-tracker-sync: rhacm-2.4.z+
Target Release:	rhacm-2.4.5
Hardware:	x86_64
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-06-27 17:04:02 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Thuy Nguyen 2022-04-14 16:28:55 UTC

Description of the problem: Deprovisioned clusters not filtered out by discovery controller

Release version:

Operator snapshot version:
2.4.3-RC3

OCP version:

Browser Info:

Steps to reproduce:
1. Delete/uninstall rosa cluster(s) on RH cloud
2. Create discovery config in ACM

Actual results:
Deleted rosa clusters are still displayed in ACM console

Expected results:

Additional info:

list of active clusters queried from RH ocm:
curl -k "https://api.openshift.com/api/accounts_mgmt/v1/subscriptions?search=(status+NOT+IN+(%27Deprovisioned%27,+%27Archived%27))&fetchCapabilities=true" -H "Authorization: Bearer $token" | jq '.items[] | "\(.display_name) - \(.console_url)"'
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 16195    0 16195    0     0  51088      0 --:--:-- --:--:-- --:--:-- 51088
"a8c8e296-d991-4649-9fda-d2730ba2348f - https://console-openshift-console.apps.slot-00.dev09.red-chesterfield.com"
"b84c275a-797b-494c-9f97-360f53de01f5 - https://console-openshift-console.apps.ocp4-gcp-dr-1.gcp.dev09.red-chesterfield.com"
"ce5c045e-dca4-410a-890b-bf76f4688e59 - https://console-openshift-console.apps.slot-06.dev09.red-chesterfield.com"
"1b39d29d-b17c-4b80-b2c3-c4276cfc3a82 - https://console-openshift-console.apps.slot-03.dev09.red-chesterfield.com"
"a0ab2acf-a4a9-407e-9f9a-0fdf63568ccd - https://console-openshift-console.apps.slot-02.dev09.red-chesterfield.com"
"cdb5b307-9310-43d3-9c96-6c244a50f12d - https://console-openshift-console.apps.ocp4-az-dr-2.az.dev06.red-chesterfield.com"


discovered cluster:
oc get discoveredclusters -n default
NAME                                   AGE
1b39d29d-b17c-4b80-b2c3-c4276cfc3a82   18m
20bb9ec0-62e8-41d8-976c-3e53d98a9d92   19m
2955e7ff-3122-4d8a-b7aa-f4c040060917   18m
a0ab2acf-a4a9-407e-9f9a-0fdf63568ccd   19m
a8c8e296-d991-4649-9fda-d2730ba2348f   18m
b84c275a-797b-494c-9f97-360f53de01f5   18m
cdb5b307-9310-43d3-9c96-6c244a50f12d   19m
ce5c045e-dca4-410a-890b-bf76f4688e59   19m


deprovisioned cluster -
oc get discoveredclusters -n default -oyaml 2955e7ff-3122-4d8a-b7aa-f4c040060917
apiVersion: discovery.open-cluster-management.io/v1alpha1
kind: DiscoveredCluster
metadata:
  creationTimestamp: "2022-04-14T16:08:05Z"
  generation: 1
  name: 2955e7ff-3122-4d8a-b7aa-f4c040060917
  namespace: default
  ownerReferences:
  - apiVersion: discovery.open-cluster-management.io/v1alpha1
    blockOwnerDeletion: true
    controller: true
    kind: DiscoveryConfig
    name: discovery
    uid: b4817fb9-f883-4592-80d9-b14dcbaacfc6
  resourceVersion: "2237911"
  uid: cdee43aa-a8bd-4b28-9ab1-8dad6aaae48a
spec:
  activityTimestamp: "2022-04-14T15:00:41Z"
  apiUrl: https://api.rosa-aws-dr-2.oh8d.p1.openshiftapps.com:6443
  cloudProvider: aws
  console: https://console-openshift-console.apps.rosa-aws-dr-2.oh8d.p1.openshiftapps.com
  creationTimestamp: "2022-04-13T18:41:57Z"
  credential:
    apiVersion: v1
    kind: Secret
    name: rh-ocm
    namespace: default
    resourceVersion: "2233715"
    uid: 1125c9bc-0107-494a-b659-2a6303ae036f
  displayName: rosa-aws-dr-2
  isManagedCluster: false
  name: 2955e7ff-3122-4d8a-b7aa-f4c040060917
  status: Deprovisioned
  type: ROSA

Comment 1 Jakob 2022-04-14 18:59:45 UTC

We currently only filter out clusters with an 'Archived' status. We can easily add a filter for 'Deprovisioned' status.

Comment 3 bot-tracker-sync 2022-05-05 15:00:12 UTC

G2Bsync 1118598382 comment 
 JakobGray Thu, 05 May 2022 14:05:56 UTC 
 G2Bsync This fix has been merged into 2.4.5

Comment 4 Jakob 2022-06-07 13:56:39 UTC

I'll close this in a few days if there is no more activity

Comment 5 bot-tracker-sync 2022-06-07 22:10:06 UTC

G2Bsync 1149080294 comment 
 thuyn-581 Tue, 07 Jun 2022 19:31:00 UTC 
 G2BSync -
Validated on 2.4.5-FC0

Comment 11 errata-xmlrpc 2022-06-27 17:04:02 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Red Hat Advanced Cluster Management 2.4.5 security updates and bug fixes), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5201