Bug 2075985

Summary:	Review Request: rust-mime2ext - Given a mimetype, suggest a file extension
Product:	[Fedora] Fedora	Reporter:	Carmelo Sarta <carmelo.sarta.main>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-11-08 00:45:33 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	201449

Description Carmelo Sarta 2022-04-16 20:08:40 UTC

Spec URL: https://raw.githubusercontent.com/Laiot/rust-mime2ext-rpm/master/rust-mime2ext.spec
SRPM URL: https://github.com/Laiot/rust-mime2ext-rpm/raw/master/rust-mime2ext-0.1.52-1.fc36.src.rpm
Description: Given a mimetype, suggest a file extension
Fedora Account System Username: laiot

Comment 1 Fabio Valentini 2022-05-01 14:21:50 UTC

I think you'll need to specify this in the -devel subpackage:

Provides: bundled(mime-db) = 1.52.0

given that this crate bundles data from another project.
Both are licensed MIT, so it's fine at least from that perspective.

I wonder what you're packaging that needs this crate?

Comment 2 Carmelo Sarta 2022-05-11 07:42:04 UTC

Sorry about the delay, I just pushed the fixed .spec

Comment 3 Fabio Valentini 2022-05-12 15:55:30 UTC

> Provides: bundled(mime-db) = 1.52.0

You added this to the wrong subpackage (the empty "meta"-package for the "default" feature) instead of "-devel".
Also, while you're at it, align the value to the same column as the others :)

Comment 4 Carmelo Sarta 2022-05-17 07:16:43 UTC

Fixed that, I hope it's correct.

Comment 5 Fabio Valentini 2022-07-16 19:46:03 UTC

Thanks, looks good to me now! Sorry for the delay.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 6 Fabio Valentini 2022-10-14 13:00:53 UTC

Refreshed fedora-review+ flag. Please continue with importing and building the package.

Comment 7 Package Review 2023-10-08 08:10:48 UTC

Package was never imported.
The ticket status is being reset, since creating the repository will require a fresh approval.
Let us know if you're still interested in this package.

Comment 8 Package Review 2023-11-08 00:45:33 UTC

This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.