Bug 2076042

Summary: Error in engine.log when converting disk format/allocation policy
Product: [oVirt] ovirt-engine Reporter: sshmulev
Component: BLL.StorageAssignee: Benny Zlotnik <bzlotnik>
Status: CLOSED CURRENTRELEASE QA Contact: Ilia Markelov <imarkelo>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.5.0.2CC: ahadas, bugs, bzlotnik, dfodor, sfishbai
Target Milestone: ovirt-4.5.1Keywords: ZStream
Target Release: ---Flags: pm-rhel: ovirt-4.5?
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ovirt-engine-4.5.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-06-23 05:54:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description sshmulev 2022-04-17 10:53:06 UTC
Description of problem:
The following error shows up in the logs every time I try to perform convert:
"Failed to prepare command of type 'ConvertDisk' for monitoring due to error 'null'"

It doesn't matter which convert, it happens each time.

Version-Release number of selected component (if applicable):
engine-4.5.0.2-0.7.el8ev
vdsm-4.50.0.12-1.el8ev.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Create raw/preallocated/incremental_disabled disk
POST engine/ovirt-engine/api/disks
<disk>
  <storage_domains>
    <storage_domain id="{{ISCSI_SD}}"/>
  </storage_domains>
  <name>ISCSI_Raw-Preallocated-Disabled</name>
  <provisioned_size>1073741824</provisioned_size>
  <format>raw</format>
  <sparse>false</sparse>
  <backup>None</backup>
</disk>

2. Convert the disk to cow/preallocated/incremental_enabled
POST engine/ovirt-engine/api/disks/{{ISCSI_Raw-Preallocated-Disabled}}/convert
<action>
    <disk>
        <format>cow</format>
        <backup>incremental</backup>
    </disk>
</action>

Actual results:
The disk is converted successfully but with the error "Failed to prepare command of type 'ConvertDisk' for monitoring due to error 'null'"

Expected results:
The disk should be converted to cow/preallocated/incremental_enabled without any error logs

Comment 2 Ilia Markelov 2022-06-13 09:16:07 UTC
Verified.

Disk is converted successfully without any error logs.

Versions:
engine-4.5.1-0.62.el8ev 
vdsm-4.50.1.1-1.el8ev.x86_64

Comment 3 Sandro Bonazzola 2022-06-23 05:54:58 UTC
This bugzilla is included in oVirt 4.5.1 release, published on June 22nd 2022.
Since the problem described in this bug report should be resolved in oVirt 4.5.1 release, it has been closed with a resolution of CURRENT RELEASE.
If the solution does not work for you, please open a new bug report.