Bug 2076455

Summary:	Review Request: golang-github-twpayne-pinentry - Provides a client to GnuPG's pinentry
Product:	[Fedora] Fedora	Reporter:	Carmelo Sarta <carmelo.sarta.main>
Component:	Package Review	Assignee:	Fabio Alessandro Locati <me>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	me, package-review
Target Milestone:	---	Flags:	me: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-04-21 07:52:24 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Carmelo Sarta 2022-04-19 05:49:42 UTC

Spec URL: https://raw.githubusercontent.com/Laiot/golang-github-twpayne-pinetry-rpm/master/golang-github-twpayne-pinentry.spec
SRPM URL: https://github.com/Laiot/golang-github-twpayne-pinetry-rpm/raw/master/golang-github-twpayne-pinentry-0.2.0-1.fc36.src.rpm
Description: Provides a client to GnuPG's pinentry
Fedora Account System Username: laiot

Comment 1 Fabio Alessandro Locati 2022-04-19 14:37:48 UTC

Hi Carmelo,

Thanks for the effort, and overall a good package!

In theory the `BuildRequires: golang(github.com/golang/mock/gomock)` should not be needed, but I think there is an issue on the mock package, which is hopefully solved by https://src.fedoraproject.org/rpms/golang-github-mock/pull-request/1, so for now we can keep it and remove it once the problem is solved.

I see a one thing to tweak before it's approvable:

The shipped binary (gen) only utility is to generate the source code, so we do not need to have it within the package, since we are already ship the output of it.

To strip the binary you should:
* Add after `%bcond_without check` the configuration to let the builder know to produce platform-independent RPM, since we are only going to ship sources:

   %global debug_package %{nil}
    

* Remove the build of the binary:

    for cmd in cmd/*; do
      %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd
    done

* Remove the installation of the binary and respective folder:

    install -m 0755 -vd                     %{buildroot}%{_bindir}
    install -m 0755 -vp %{gobuilddir}/bin/* %{buildroot}%{_bindir}/

* Since we only need to put files in the -devel package, we can also remove the whole %file block since %gopkgfiles will take care of all files and put them in the right location without help:

    %files
    %license LICENSE
    %doc README.md
    %{_bindir}/*

Comment 2 Carmelo Sarta 2022-04-19 14:45:45 UTC

Hey Fale!
Thanks for the review. I've just pushed the adjustments.

Comment 3 Fabio Alessandro Locati 2022-04-19 19:59:32 UTC

go2rpm package, fedora-review is correct:

- The specfile is sane.
- License is correct
- Builds successfully in mock
- No rpmlint errors
- %check section passes
- The latest version is packaged
- The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- Add package to release-monitoring.org
- Add package to Koschei.
- Give go-sig privileges on package
- Close the review bug by referencing it in the rpm changelog and/or the Bodhi ticket. (rhbz#BUG_ID)

Thanks!

Comment 4 Gwyn Ciesla 2022-04-19 20:19:43 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-twpayne-pinentry