Bug 2076544

Summary: Whitespace (padding) is missing after an PatternFly update, already in 4.10
Product: OpenShift Container Platform Reporter: Christoph Jerolimov <cjerolim>
Component: Dev ConsoleAssignee: Lokananda Prabhu <lprabhu>
Status: CLOSED ERRATA QA Contact: spathak <spathak>
Severity: low Docs Contact:
Priority: medium    
Version: 4.10CC: aos-bugs, lprabhu, nmukherj
Target Milestone: ---   
Target Release: 4.11.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-08-10 11:07:40 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
pipeline-builder-master.png
none
pipeline-builder-4.9.png
none
create-silence-4.9.png
none
create-silence-master.png
none
operator-hub-4.9.png
none
operatorhub-master.png none

Description Christoph Jerolimov 2022-04-19 10:19:39 UTC
Description of problem:
Found some small UI issues in 4.10, still existing in 4.11 where some whitespace (padding or margin) is missing after some custom CSS is removed.

This happened with the merge of https://github.com/openshift/console/pull/10649.

In _patternfly4.scss it removes the really generic rule:

  p {
    margin-bottom: var(--pf-c-content--MarginBottom);
  }

PatternFly uses this rule instead.

  .pf-c-content p { 
    margin-bottom: var(--pf-c-content--MarginBottom)
  }


Version-Release number of selected component (if applicable):
4.10 and 4.11


How reproducible:
Always (Layout issue)


Steps to Reproduce:
Different pages are affected. We should search for all <p> in our code to check if the layout breaks/changes from 4.9 to 4.10? 

For example:
1. Pipelines > Pipeline Builder
2. Observe > Alerts > Silence > Create

Many others are less obvious - and sometimes not bad at all. Like the OperatorHub info text message.

Actual results:
Spacing is missing. At least on the Pipeline Bilder and Alert Silence Create page.

Expected results:
Spacing should be shown as before WITHOUT restoring this rule.

As part of a fix for this we should search for other spacing issues as well.
Please search for <p> and pf-c-content in our complete code base.


Additional info:
We don’t want to restore this rule since it causes problems for plugins that use pure PF components and layouts.

We should fix the specific places you see issues. We’re trying to move away from any overrides of the base PF styles.

See also https://coreos.slack.com/archives/C6A3NV5J9/p1644482983095689

Comment 1 Christoph Jerolimov 2022-04-19 10:20:41 UTC
Created attachment 1873488 [details]
pipeline-builder-master.png

Comment 2 Christoph Jerolimov 2022-04-19 10:21:03 UTC
Created attachment 1873489 [details]
pipeline-builder-4.9.png

Comment 3 Christoph Jerolimov 2022-04-19 10:21:45 UTC
Created attachment 1873491 [details]
create-silence-4.9.png

Comment 4 Christoph Jerolimov 2022-04-19 10:22:00 UTC
Created attachment 1873494 [details]
create-silence-master.png

Comment 5 Christoph Jerolimov 2022-04-19 10:22:33 UTC
Created attachment 1873495 [details]
operator-hub-4.9.png

Comment 6 Christoph Jerolimov 2022-04-19 10:22:51 UTC
Created attachment 1873496 [details]
operatorhub-master.png

Comment 9 Christoph Jerolimov 2022-05-23 08:50:15 UTC
Verified on 4.11.0-0.nightly-2022-05-20-213928

Comment 11 errata-xmlrpc 2022-08-10 11:07:40 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Container Platform 4.11.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5069