Bug 2076825

Summary: Review Request: python-pytest-asyncio - Pytest support for asyncio
Product: [Fedora] Fedora Reporter: Carl George 🎩 <carl>
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: ngompa13, package-review
Target Milestone: ---Flags: ngompa13: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-04-20 19:47:39 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Carl George 🎩 2022-04-20 03:10:16 UTC 
Spec URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/04288329-python-pytest-asyncio/python-pytest-asyncio.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/04288329-python-pytest-asyncio/python-pytest-asyncio-0.18.3-1.fc37.src.rpm

Description:
pytest-asyncio is an Apache2 licensed library, written in Python, for testing
asyncio code with pytest.

asyncio code is usually written in the form of coroutines, which makes it
slightly more difficult to test using normal testing tools. pytest-asyncio
provides useful fixtures and markers to make testing easier.

Fedora Account System Username: carlwgeorge

This is a re-review of this package to rename [0] the source package from python3-pytest-asyncio to python-pytest-asyncio, which is required to comply with the Python package guidelines [1].  Obsoletes and provides are not required because the resulting binary package has the same name.


[0] https://docs.fedoraproject.org/en-US/package-maintainers/Package_Renaming_Process/
[1] https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_library_naming
Comment 1 Neal Gompa 2022-04-20 03:16:01 UTC 
Review notes:

* Package outputs are the same before and after
* Packaging follows packaging guidelines
* Package licensing is correct and license files are installed properly

Nits:

* There's a missing "%bcond_with tests" definition to go with the "%bcond_without tests" one.
* The usage of "%if %{defined ...}" is a bit unconventional, but fine.

In any case...

PACKAGE APPROVED.
Comment 2 Gwyn Ciesla 2022-04-20 13:45:36 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pytest-asyncio
Comment 3 Fedora Update System 2022-04-20 19:45:41 UTC 
FEDORA-2022-cf4484dc5d has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-cf4484dc5d
Comment 4 Fedora Update System 2022-04-20 19:47:39 UTC 
FEDORA-2022-cf4484dc5d has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.