Bug 207715

David, any ideas?

Hi, please try with hal-0.5.8 and gnome-mount 0.5 available from here

 http://people.freedesktop.org/~david/hal-0.5.8.1-fc6/

Thanks.

> please try with hal-0.5.8 and gnome-mount 0.5

Thanks.  I did.  A floppy icon in "Computer" came back, and I can
indeed mount and unmount floppy with its help.  Also 
'gnome-mount -d /dev/fd0' works again (adding '-v' does not provide
any extra information).  It takes a while to mount but eventually it
does.  BUT after these updates I ended up with the situation like
in the original report but for a change with CD this time.
I.e. no icon, no desktop mounts, and 'gnome-mount -d /dev/cdrom'
just returns right away (with a mountable, iso9660, CD in a drive).

There is another issue.  I have x86_64 installation and I had to
rebuild binary packages for it.  To get hal to recompile I had to
install 'libvolume_id' package (and some "-devel" packages but this
is not likely affect results).  That package is not mentioned anywhere
in requirements and nothing appeared to complain that it was not
installed before.  OTOH when I tried to remove it afterwards, just
to see what will happen, yum wanted to remove over 130 packages; most
likely due to direct or indirect dependencies on hal.  Would
ready new binary packages pulled in 'libvolume_id' too?  I wonder
if its absence before was a reason for an observed behaviour
(but why now CDs?).

Also earlier updates happened on my test system
August 31st - hal.x86_64 0.5.7.1-3.fc6
July 26     - gnome-mount.x86_64 0.4.0.2006.07.24-1.fc6
and I am pretty sure that I was looking at floppies after that.
Definitely with the previous version of gnome-mount.  Hence I suspected
that other components are really involved here.

> BUT after these updates I ended up with the situation like
> in the original report but for a change with CD this time.
> I.e. no icon, no desktop mounts, and 'gnome-mount -d /dev/cdrom'
> just returns right away (with a mountable, iso9660, CD in a drive).

Very weird, I get that too one a box. Have never seen this before,
am debugging it right now. Will follow up with newer packages.

> To get hal to recompile I had to
> install 'libvolume_id' package 

Yea, I missed the BR on libvolume_id-devel and the R on libvolume_id. Only
realized that when going over the spec file.

(for 0.5.7 and earlier we were carrying a copy of the code in the udev tree, now
udev provides this as a shared library).

Thanks for the testing so far.

OK, this was an easy fix. A helper spawned by hald to investigate the storage
device crashes on a code path for CD-ROM drives without write capabilities.

I guess these are just rare these days. Not part of my testing setup the past 8
months as I've been working from another location than the Westford office.

Patch is here

http://gitweb.freedesktop.org/?p=hal.git;a=commitdiff;h=c127f54ee1a91743989ccdbe93025740fe9cec73

Will build new packages in a bit; just scanning other bugs I've put in NEEDINFO.

Here's a src RPM with the patch

 http://people.freedesktop.org/~david/hal-0.5.8.1-fc6/hal-0.5.8.1-0davidz2.src.rpm

Thanks,
David

> Here's a src RPM with the patch

Thanks.  After replacing hal with that one I do have back both floppy
and CD; and a filesystem on a USB memory stick mounts as well.

OTOH my particular device identifies itsels as:
"ATAPI 52X CD-ROM CD-R/RW drive, 2048kB Cache, UDMA(33)" so I am not
sure if
"crashes on a code path for CD-ROM drives without write capabilities"
diagnosis is really correct but your patch appears to prevent a crash
in this case too.

OK, thanks for testing. 

Actually, looking through it again, the code path is when we can't get the write
speeds from the device - I was making the wrong assumption. Perhaps your drive
don't support that MMC command (MMC-3 Current Write Speed).

Should be fixed with hal 0.5.8.1-2 / gnome-mount 0.5-2 otherwise please reopen.